added opus 1.5.1 #23234

dmpriso · 2024-03-24T21:33:04Z

Specify library name and version: opus/1.5.1

Added new opus version with support for DRED and deep PLC

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2024-03-24T21:33:09Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ dmpriso
❌ Daniel

Daniel seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

recipes/opus/all/conanfile.py

valgur

LGTM, only need to add CMP0077. Thanks!

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

dmpriso · 2024-03-28T17:47:42Z

I'm not used to using conan, I just made small adaptions to the given recipe in order to support opus 1.5.1.
If someone points me to the right direction, I'd happily have a look at the failed checks, if they are relevant.

Croydon · 2024-03-28T18:42:49Z

@dmpriso You need to write a short comment in this issue -> #4, then you are going to be added and CI runs for your pull requests

dmpriso · 2024-04-01T20:08:20Z

There seems to be a TLS issue when downloading the builds from xiph.org

dmpriso · 2024-04-22T08:47:13Z

Anything I can do about this? The releases are hosted on xiph.org, but somehow the build servers don't accept the certificate or TLS version, see e.g. https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23234/4-linux-gcc/opus/1.5.1//1d2e365eb8c339034b0dc24d7dd442ac92ae783a-build.txt

Croydon · 2024-04-22T20:09:33Z

Might have been a temporary thing since it only happened in a Conan v2 build. v1 had a regular build failure

conan-center-bot · 2024-04-22T21:05:51Z

Conan v1 pipeline ❌

Failure in build 5 (437af56d6810a4acd4230b1d6312890dfda9dc56):

opus/1.5.1:
CI failed to create some packages (All logs)

Logs for packageID ad9b75a07d2c315af9f5d76a94659383b6f16e46:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=5
os=Linux
[options]
opus:shared=False

[...]
************************************************************************************



Default settings
	os=Linux
	os_build=Linux
	arch=x86_64
	arch_build=x86_64
	compiler=gcc
	compiler.version=5
	compiler.libcxx=libstdc++
	build_type=Release
*** You can change them in /home/conan/workspace/prod-v1/bsr/29856/cdeaa/.conan/profiles/default ***
*** Or override with -s compiler='other' -s ...s***


Configuration:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.libcxx=libstdc++11
compiler.version=5
os=Linux
[options]
opus:shared=False
[build_requires]
[env]
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

opus/1.5.1: Forced build from source
Installing package: opus/1.5.1
Requirements
    opus/1.5.1 from local cache - Cache
Packages
    opus/1.5.1:ad9b75a07d2c315af9f5d76a94659383b6f16e46 - Build

Installing (downloading, building) binaries...
[HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
opus/1.5.1: Configuring sources in /home/conan/workspace/prod-v1/bsr/29856/cdeaa/.conan/data/opus/1.5.1/_/_/source/src
opus/1.5.1: Waiting 5 seconds to retry...
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
opus/1.5.1: ERROR: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'
ERROR: opus/1.5.1: Error in source() method, line 59
	destination=self.source_folder, strip_root=True)
	ConanException: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'

opus/1.4:
Didn't run or was cancelled before finishing
opus/1.3.1:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 5 (437af56d6810a4acd4230b1d6312890dfda9dc56):

opus/1.5.1:
CI failed to create some packages (All logs)

Logs for packageID 1d2e365eb8c339034b0dc24d7dd442ac92ae783a:

[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False

[...]
Profile host:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[options]
*/*:shared=False
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True

Profile build:
[settings]
arch=x86_64
build_type=Release
compiler=gcc
compiler.cppstd=17
compiler.libcxx=libstdc++11
compiler.version=11
os=Linux
[conf]
tools.system.package_manager:mode=install
tools.system.package_manager:sudo=True


======== Computing dependency graph ========
Graph root
    cli
Requirements
    opus/1.5.1#ab76c5f0eb6f3cc117a2b92d8ce0ed59 - Cache

======== Computing necessary packages ========
opus/1.5.1: Forced build from source
Requirements
    opus/1.5.1#ab76c5f0eb6f3cc117a2b92d8ce0ed59:1d2e365eb8c339034b0dc24d7dd442ac92ae783a - Build

======== Installing packages ========
opus/1.5.1: Calling source() in /home/conan/workspace/prod-v2/bsr/26616/cebbd/p/opuse1cd8dabf4227/s/src
opus/1.5.1: WARN: File https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz not found in https://c3i.jfrog.io/artifactory/conan-center-backup-sources/
opus/1.5.1: WARN: network: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'
opus/1.5.1: Waiting 5 seconds to retry...
opus/1.5.1: WARN: network: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'
opus/1.5.1: Waiting 5 seconds to retry...
ERROR: opus/1.5.1: Error in source() method, line 59
	destination=self.source_folder, strip_root=True)
	ConanException: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'

opus/1.4:
Didn't run or was cancelled before finishing
opus/1.3.1:
Didn't run or was cancelled before finishing

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

ericLemanissierBot · 2024-04-24T15:14:44Z

I detected other pull requests that are modifying opus/all recipe:

refactor: opus test_package #23752

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

Croydon · 2024-04-24T20:50:24Z

recipes/opus/all/conandata.yml

+  "1.5.1":
+    url: "https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz"
+    sha256: "b84610959b8d417b611aa12a22565e0a3732097c6389d19098d844543e340f85"


Suggested change

"1.5.1":

url: "https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz"

sha256: "b84610959b8d417b611aa12a22565e0a3732097c6389d19098d844543e340f85"

"1.5.2":

url:

- "https://ftp.osuosl.org/pub/xiph/releases/opus/opus-1.5.2.tar.gz"

- "https://downloads.xiph.org/releases/opus/opus-1.5.2.tar.gz"

sha256: "65c1d2f78b9f2fb20082c38cbe47c951ad5839345876e46941612ee87f9a7ce1"

The downloads.xiph.org seems to redirect to mirrors. So let's try to use one of them as the preferred download.
For older versions we also have used their GitHub downloads, but they did not upload them there for 1.5x. And we also used a Mozilla mirror, but they don't seem to have these versions yet either.

Checksum is taken from https://opus-codec.org/release/stable/2024/04/12/libopus-1_5_2.html

And let's use 1.5.2 instead of 1.5.1 at this point

Croydon · 2024-04-24T20:50:35Z

recipes/opus/config.yml

@@ -1,4 +1,6 @@
 versions:
+  "1.5.1":


Suggested change

"1.5.1":

"1.5.2":

Croydon · 2024-04-25T00:50:06Z

For protocol, the error is

opus/1.5.1: ERROR: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'
ERROR: opus/1.5.1: Error in source() method, line 59
	destination=self.source_folder, strip_root=True)
	ConanException: Error downloading file https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz: 'HTTPSConnectionPool(host='downloads.xiph.org', port=443): Max retries exceeded with url: /releases/opus/opus-1.5.1.tar.gz (Caused by SSLError(SSLError(1, '[SSL: TLSV1_ALERT_PROTOCOL_VERSION] tlsv1 alert protocol version (_ssl.c:1091)')))'

downloads.xiph.org seems to support ONLY TLS 1,3, not any older versions.
ftp.osuosl.org seems to only support TLS 1.2, not any other version.

The Python 3.7 version in the docker containers is using the following OpenSSL version: OpenSSL 1.0.2g 1 Mar 2016
Printed via

import ssl
[...]
    def configure(self):
        self.output.info(ssl.OPENSSL_VERSION)

OpenSSL added TLS 1.3 support in 1.1.1+

Using the mirror directly as in my code suggestion above we should be able to workaround this problem for now.

added opus 1.5.1

923cfe9

conan-center-bot added the User-approval pending label Mar 24, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into update-opus-1.5.1

891876d

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Mar 24, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

valgur reviewed Mar 24, 2024

View reviewed changes

recipes/opus/all/conanfile.py Show resolved Hide resolved

valgur suggested changes Mar 24, 2024

View reviewed changes

ericLemanissier mentioned this pull request Mar 25, 2024

Updatable recipes ericLemanissier/conan-center-bot#1

Closed

This was referenced Mar 26, 2024

Updatable recipes qchateau/conan-center-bot#1

Open

[request] Updatable recipes #3470

Open

Added CMP0077 as suggested

0e23f4f

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

This comment has been minimized.

Sign in to view

dmpriso mentioned this pull request Mar 28, 2024

[!!] Access request #4

Open

Merge branch 'master' into update-opus-1.5.1

2261339

conan-center-bot added Failed and removed User-approval pending labels Apr 1, 2024

This comment has been minimized.

Sign in to view

Merge branch 'master' into update-opus-1.5.1

437af56

This was referenced Apr 24, 2024

refactor: opus test_package #23752

Merged

[service] Potentially conflicting recipes #3571

Closed

Croydon suggested changes Apr 24, 2024

View reviewed changes

Croydon mentioned this pull request Apr 25, 2024

TLS 1.3 connections for source downloads are unsupported conan-io/conan-docker-tools#583

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added opus 1.5.1 #23234

added opus 1.5.1 #23234

dmpriso commented Mar 24, 2024

CLAassistant commented Mar 24, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

valgur left a comment

This comment has been minimized.

dmpriso commented Mar 28, 2024

Croydon commented Mar 28, 2024 •

edited

This comment has been minimized.

dmpriso commented Apr 1, 2024

dmpriso commented Apr 22, 2024

Croydon commented Apr 22, 2024

conan-center-bot commented Apr 22, 2024

ericLemanissierBot commented Apr 24, 2024

Croydon Apr 24, 2024

Croydon Apr 24, 2024

Croydon commented Apr 25, 2024 •

edited

-  "1.5.1":
-    url: "https://downloads.xiph.org/releases/opus/opus-1.5.1.tar.gz"
-    sha256: "b84610959b8d417b611aa12a22565e0a3732097c6389d19098d844543e340f85"
+  "1.5.2":
+    url:
+      - "https://ftp.osuosl.org/pub/xiph/releases/opus/opus-1.5.2.tar.gz"
+      - "https://downloads.xiph.org/releases/opus/opus-1.5.2.tar.gz"
+    sha256: "65c1d2f78b9f2fb20082c38cbe47c951ad5839345876e46941612ee87f9a7ce1"

added opus 1.5.1 #23234

Are you sure you want to change the base?

added opus 1.5.1 #23234

Conversation

dmpriso commented Mar 24, 2024

CLAassistant commented Mar 24, 2024 • edited

This comment has been minimized.

This comment has been minimized.

valgur left a comment

Choose a reason for hiding this comment

This comment has been minimized.

dmpriso commented Mar 28, 2024

Croydon commented Mar 28, 2024 • edited

This comment has been minimized.

dmpriso commented Apr 1, 2024

dmpriso commented Apr 22, 2024

Croydon commented Apr 22, 2024

conan-center-bot commented Apr 22, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ❌

ericLemanissierBot commented Apr 24, 2024

Croydon Apr 24, 2024

Choose a reason for hiding this comment

Croydon Apr 24, 2024

Choose a reason for hiding this comment

Croydon commented Apr 25, 2024 • edited

CLAassistant commented Mar 24, 2024 •

edited

Croydon commented Mar 28, 2024 •

edited

Croydon commented Apr 25, 2024 •

edited