Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

qt/6: Use libglvnd on FreeBSD and Linux #23279

Closed
wants to merge 2 commits into from
Closed

qt/6: Use libglvnd on FreeBSD and Linux #23279

wants to merge 2 commits into from

Conversation

jwillikers
Copy link
Contributor

The libglvnd package provides the necessary opengl/system and egl/system dependencies on FreeBSD and Linux. The libglvnd package is a proper, non-system Conan package. This PR also removes an unnecessary check for wayland being enabled in xkbcommon. The Wayland option in xkbcommon only effects building an executable tool.

@github-actions GitHub Actions
Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/qt//'.

👋 @ericLemanissier @jwillikers @MartinDelille @paulharris you might be interested. 😉

@ericLemanissierBot
Copy link

ericLemanissierBot commented Mar 26, 2024 •
edited

I detected other pull requests that are modifying qt/6.x.x recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

This was referenced Mar 26, 2024
Closed
Merged
Open
@jwillikers
qt/6: Use libglvnd on FreeBSD and Linux
02b52a6 
The libglvnd package provides the necessary opengl/system and egl/system dependencies.
The libglvnd package is a proper, non-system Conan package.
Remove unnecessary check for wayland being enabled in xkbcommon.
The Wayland option in xkbcommon only effects building an executable tool.
@prince-chrismc prince-chrismc mentioned this pull request Mar 26, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit 02b52a6
qt/6.6.2@#ce6d32f9e4bff1ead94f8030a3a5cd9f 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.1@#fff0af0cff4db2e18a02875eaeef6cbf 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.0@#a5b37d33ca74172cd2c986ec97243fff 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.5.3@#5902b4ee5ee374c0ab6dc32f5531b1f6 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.4.2@#00548d57924207e65ddbba100ee9f79a 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.3.2@#d9766f056df2d6caf1c38964e778dedd 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.

ericLemanissier
ericLemanissier suggested changes Mar 27, 2024
View reviewed changes
Copy link
Contributor

@ericLemanissier ericLemanissier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something is not coherent between requirements(self) and package_info(self): egl/system is required but never referenced as requirement of a component.
It'd be better if all the requirements and components where defined in a common place (function or structure) which would then be exploited by requires(self) and package_info(self). I wish I had done this from the start, the work is much bigger now :/

@jwillikers
Copy link
Contributor Author

something is not coherent between requirements(self) and package_info(self): egl/system is required but never referenced as requirement of a component. It'd be better if all the requirements and components where defined in a common place (function or structure) which would then be exploited by requires(self) and package_info(self). I wish I had done this from the start, the work is much bigger now :/

I think I've fixed the missing egl. I think an approach like that would be really helpful for a lot of recipes, especially large ones. Do we we have any recipes that do something like that already?

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (f431abfb4c09296e4cbe43b59ae6386801a24cad):

  • qt/6.6.2:
    All packages built successfully! (All logs)

  • qt/6.6.1:
    All packages built successfully! (All logs)

  • qt/6.5.3:
    All packages built successfully! (All logs)

  • qt/6.3.2:
    All packages built successfully! (All logs)

  • qt/6.6.0:
    All packages built successfully! (All logs)

  • qt/6.4.2:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 3 (f431abfb4c09296e4cbe43b59ae6386801a24cad):

  • qt/6.6.1:
    All packages built successfully! (All logs)

  • qt/6.4.2:
    All packages built successfully! (All logs)

  • qt/6.3.2:
    All packages built successfully! (All logs)

  • qt/6.6.2:
    All packages built successfully! (All logs)

  • qt/6.6.0:
    All packages built successfully! (All logs)

  • qt/6.5.3:
    All packages built successfully! (All logs)

@github-actions GitHub Actions
Copy link
Contributor

Hooks produced the following warnings for commit f431abf
qt/6.6.2@#9187bd2093309dbf5a95635a0ebd092d 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.6.1@#d5f812858269c15598c1c2aa952c9074 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.5.3@#951d24ec715efa3a60e128280ced3dfe 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.3.2@#7ffa894640f2f9fa8795402f9e836e4c 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
qt/6.6.0@#9ff7e9d339bf97c578112839520f1cd3 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackendd.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library '.\res\archdatadir\plugins\tls\qschannelbackend.dll' links to system library 'ncrypt' but it is not in cpp_info.system_libs.
qt/6.4.2@#3e8a7faf08755c2c6d5c883ba477b0af 
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa_debug.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.
post_package(): WARN: [MISSING SYSTEM LIBS (KB-H043)] Library './res/archdatadir/plugins/platforms/libqcocoa.dylib' links to system library 'ColorSync' but it is not in cpp_info.frameworks.

@ericLemanissierBot ericLemanissierBot mentioned this pull request Apr 2, 2024
Merged
3 tasks
This was referenced Apr 10, 2024
Closed
Open
Closed
Closed
@jcar87 jcar87 mentioned this pull request Apr 19, 2024
Open
@jcar87
Copy link
Contributor

jcar87 commented Apr 19, 2024

Closing pending discussion at #23649

Also perhaps relevant to Qt only: back in the day, the generated *-config.cmake files would actually reference some of the OpenGL libraries with a full, absolute path. WHich can be okay on some Linux systems assuming they reference a system location, but certainly not if this were to be pointing to a binary in the Conan cache. On the other hand, we are not using thoe files in Conan, but it's worth noting.

@jcar87 jcar87 closed this Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericLemanissier ericLemanissier ericLemanissier requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jwillikers @ericLemanissierBot @conan-center-bot @jcar87 @ericLemanissier