Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use (ftp.gnu.org) as fallback of (ftpmirror.gnu.org), as the second might fail due to unsafe crypto #23281

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

es20490446e
Copy link
Contributor

@es20490446e es20490446e commented Mar 26, 2024

With the departure towards OpenSSL 3 some mirrors are still using old unsafe renegotiation, and that's preventing from building this recipe.

I have noticed the mirror here about the issue, but for the time being it's just better to use the non mirrored FTP.

I will edit this back when I'm noticed it's fixed.

autoconf/2.71: ERROR: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))' ERROR: autoconf/2.71: Error in source() method, line 51
get(self, **self.conan_data["sources"][self.version], strip_root=True)
ConanException: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))'

Specify library name and version: lib/1.0


With the departure towards OpenSSL some mirrors are still using old unsafe renegotiation, and that's preventing from building this recipe.

I have noticed the mirror here about the issue, but from the time being it's just better to use the non mirrored FTP.

autoconf/2.71: ERROR: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))'
ERROR: autoconf/2.71: Error in source() method, line 51
        get(self, **self.conan_data["sources"][self.version], strip_root=True)
        ConanException: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))'
@CLAassistant
Copy link

CLAassistant commented Mar 26, 2024

CLA assistant check
All committers have signed the CLA.

@conan-center-bot

This comment has been minimized.

@es20490446e
Copy link
Contributor Author

Shall I perform any extra action?

Is it mandatory that I port this recipe for this change to be accepted?

@jcar87
Copy link
Contributor

jcar87 commented Mar 27, 2024

Shall I perform any extra action?

Is it mandatory that I port this recipe for this change to be accepted?

The recipe is already compatible, this was an issue as the CLA was not signed by the time the build started.

I can relaunch it, however, I would advise to apply the changes as suggested by @valgur and list two URLs instead of just one.

As reviewers this is a constant back and forth - some experience issues with ftp.gnu.org and others have intermittent issues with specific mirrors in ftpmirror.gnu.org. Given that Conan can easily fallback, I'd suggest listing both URLS, perhaps with ftpmirror.gnu.org as the first attempt, as advised by GNU themselves:

https://www.gnu.org//server/mirror.html

We recommend using this generic ftpmirror.gnu.org address wherever possible in links, documentation, etc., to reduce load on the main GNU server.

Listing just one may work for you today, but not for others, or not in the future, so the fallback is probably sensible.

On the other hand, if there an issue with the mirrors, especially on systems with new OpenSSL 3, I would advise reporting this issue to GNU directly - the closest contact information I can find related to mirrors is at webmasters@gnu.org. I think it's sensible that it should be pointed out that clients on newer OpenSSL, that some mirrors are not complying with https://www.rfc-editor.org/rfc/rfc5746.html - if this can be confirmed.

@es20490446e
Copy link
Contributor Author

Sorry, I thought the suggestion was already applied. Let me add it...

And about reporting the issue to GNU, I have already done it.

They replied that multiple mirrors have the issue. I guess it is on their side now.

es20490446e and others added 2 commits March 27, 2024 18:41
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
@es20490446e
Copy link
Contributor Author

Suggestions applied: ready to merge 👍

@conan-center-bot

This comment has been minimized.

1 similar comment
@conan-center-bot

This comment has been minimized.

@es20490446e
Copy link
Contributor Author

@conan-io/barbarians

@conan-center-bot

This comment has been minimized.

@es20490446e es20490446e changed the title Don't use ftpmirror.gnu.org, as it might fail Use ftp.gnu.org as fallback of ftpmirror.gnu.org, as the second might fail due to unsafe crypto Mar 27, 2024
@conan-center-bot

This comment has been minimized.

@es20490446e es20490446e changed the title Use ftp.gnu.org as fallback of ftpmirror.gnu.org, as the second might fail due to unsafe crypto Use (ftp.gnu.org) as fallback of (ftpmirror.gnu.org), as the second might fail due to unsafe crypto Mar 27, 2024
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@es20490446e
Copy link
Contributor Author

@conan-io/barbarians This pull request seems ready to merge.

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 9 (d4ae38dff7862fba8968a834b3cd033848a89d87):

  • autoconf/2.72:
    All packages built successfully! (All logs)

  • autoconf/2.71:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 8 (d4ae38dff7862fba8968a834b3cd033848a89d87):

  • autoconf/2.72:
    All packages built successfully! (All logs)

  • autoconf/2.71:
    All packages built successfully! (All logs)

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RubenRBS RubenRBS self-assigned this Apr 1, 2024
@es20490446e
Copy link
Contributor Author

@RubenRBS 👌😉

@conan-center-bot conan-center-bot merged commit 89ffa7d into conan-io:master Apr 2, 2024
18 checks passed
@es20490446e es20490446e deleted the patch-1 branch April 2, 2024 11:05
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
…, as the second might fail due to unsafe crypto

* Don't use ftpmirror.gnu.org, as it might fail

With the departure towards OpenSSL some mirrors are still using old unsafe renegotiation, and that's preventing from building this recipe.

I have noticed the mirror here about the issue, but from the time being it's just better to use the non mirrored FTP.

autoconf/2.71: ERROR: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))'
ERROR: autoconf/2.71: Error in source() method, line 51
        get(self, **self.conan_data["sources"][self.version], strip_root=True)
        ConanException: Error downloading file https://ftpmirror.gnu.org/autoconf/autoconf-2.71.tar.xz: 'HTTPSConnectionPool(host='ftp.rediris.es', port=443): Max retries exceeded with url: /mirror/GNU/autoconf/autoconf-2.71.tar.xz (Caused by SSLError(SSLError(1, '[SSL: UNSAFE_LEGACY_RENEGOTIATION_DISABLED] unsafe legacy renegotiation disabled (_ssl.c:1006)')))'

* autoconf/all/conandata.yml: fallback urls: v2.72

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

* autoconf/all/conandata.yml: fallback urls: v2.71

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>

* autoconf: conandata.yml: Lint urls properly

---------

Co-authored-by: Martin Valgur <martin.valgur@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants