-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: duckdb 0.10.1 jemalloc no longer built for non ARM Linux #23308
Conversation
Conan v1 pipeline ✔️All green in build 1 (
Conan v2 pipeline ✔️
All green in build 1 (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi! Thanks a lot for taking the time to fix this
I also think this warrants some changes to the validate()
method of the recipe to notify Conan that this combination is not possible? wdty? Pinging @uilianries too for his opinion too :)
Is this question directed at me? |
@RubenRBS I see no direct dependency to jemalloc/5.3.0 package in this recipe 🤔 It would need more investigation to understand, but in the current condition, changing only cpp_info, looks correct to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After checking with @uilianries this looks good, we got confused for a second there, sorry about the noise :)
Approving now
Specify library name and version: duckdb/0.10.1
The recipe did not build on ARM Linux.
Here is an analog change in the setup.py provided by duckdb:
duckdb/duckdb@4a89d97