Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: duckdb 0.10.1 jemalloc no longer built for non ARM Linux #23308

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

Taepper
Copy link
Contributor

@Taepper Taepper commented Mar 29, 2024

Specify library name and version: duckdb/0.10.1

The recipe did not build on ARM Linux.

Here is an analog change in the setup.py provided by duckdb:
duckdb/duckdb@4a89d97


@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (64c892fc0c6e76b406df55ee4a2d06d5d3e3d078):

  • duckdb/0.5.1:
    All packages built successfully! (All logs)

  • duckdb/0.8.0:
    All packages built successfully! (All logs)

  • duckdb/0.9.0:
    All packages built successfully! (All logs)

  • duckdb/0.6.1:
    All packages built successfully! (All logs)

  • duckdb/0.8.1:
    All packages built successfully! (All logs)

  • duckdb/0.10.1:
    All packages built successfully! (All logs)

  • duckdb/0.6.0:
    All packages built successfully! (All logs)

  • duckdb/0.9.2:
    All packages built successfully! (All logs)

  • duckdb/0.7.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (64c892fc0c6e76b406df55ee4a2d06d5d3e3d078):

  • duckdb/0.9.2:
    All packages built successfully! (All logs)

  • duckdb/0.6.0:
    All packages built successfully! (All logs)

  • duckdb/0.5.1:
    All packages built successfully! (All logs)

  • duckdb/0.8.0:
    All packages built successfully! (All logs)

  • duckdb/0.6.1:
    All packages built successfully! (All logs)

  • duckdb/0.9.0:
    All packages built successfully! (All logs)

  • duckdb/0.7.1:
    All packages built successfully! (All logs)

  • duckdb/0.8.1:
    All packages built successfully! (All logs)

  • duckdb/0.10.1:
    All packages built successfully! (All logs)

@RubenRBS RubenRBS self-assigned this Apr 1, 2024
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot for taking the time to fix this

I also think this warrants some changes to the validate() method of the recipe to notify Conan that this combination is not possible? wdty? Pinging @uilianries too for his opinion too :)

@Taepper
Copy link
Contributor Author

Taepper commented Apr 3, 2024

I also think this warrants some changes to the validate() method of the recipe to notify Conan that this combination is not possible?

Is this question directed at me?

@uilianries
Copy link
Member

@RubenRBS I see no direct dependency to jemalloc/5.3.0 package in this recipe 🤔 It would need more investigation to understand, but in the current condition, changing only cpp_info, looks correct to me.

Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After checking with @uilianries this looks good, we got confused for a second there, sorry about the noise :)

Approving now

@conan-center-bot conan-center-bot merged commit 0b2998d into conan-io:master Apr 4, 2024
54 checks passed
yhsng pushed a commit to yhsng/conan-center-index that referenced this pull request Apr 12, 2024
ericLemanissier pushed a commit to ericLemanissier/conan-center-index that referenced this pull request Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants