Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add LibRaw 0.22.0-Devel202403 development snapshot with a ton of newl… #23315

Closed

Conversation

irieger
Copy link
Contributor

@irieger irieger commented Mar 30, 2024

Specify library name and version: libraw/0.22.0-devel202403

Add LibRaw 0.22.0-Devel202403 development snapshot with a ton of newly supported image file formats. As there is only irregular releases every ~18 Months for LibRaw, development snapshot versions are offered to allow early access to features. As LibRaw is a library to read raw photo image formats and there is often new cameras introduced with slight changes in the image format, regular updates are helpful.

Is it viable to introduce this to cci? Already added it to my local artifactory so not too urgent for me but I'd assume this can also be helpful for other users.


Copy link
Contributor

🤖 Beep Boop! This pull request is making changes to 'recipes/libraw//'.

👋 @irieger you might be interested. 😉

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 1 (8d5ac26371ed9f8c7755baad2407486cf67d4ab1):

  • libraw/0.22.0-devel202403:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 1 (8d5ac26371ed9f8c7755baad2407486cf67d4ab1):

  • libraw/0.22.0-devel202403:
    All packages built successfully! (All logs)

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 30, 2024

I don't think it's a good idea to add a version coming from a fork. Nobody reviews your fork, and no offense, it could be malicious.

@irieger
Copy link
Contributor Author

irieger commented Mar 30, 2024

I don't think it's a good idea to add a version coming from a fork. Nobody reviews your fork, and no offense, it could be malicious.

The only reason was to trigger a release of a commit from the original repository without any additional changes. However I understand the problem. Sadly the snapshot is not officially tagged & released on the original repository. Would there be a consistent way on github to get a fixed archive URL with fixed checksum to a specific commit properly?

@uilianries
Copy link
Member

@irieger Why not just asking the upstream to create a new tag instead?

@uilianries uilianries self-assigned this Apr 1, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking for discussion first about the fork.

@irieger
Copy link
Contributor Author

irieger commented Apr 1, 2024

@irieger Why not just asking the upstream to create a new tag instead?

On it, just requested the tagging there.

@irieger
Copy link
Contributor Author

irieger commented Apr 1, 2024

It seems to be a very fluid thing with this "snapshot" so I'll close this MR and just keep my personal conanfile with the current tag or maybe switch it to use newer commits later.

(LibRaw/LibRaw#637 (comment))

@irieger irieger closed this Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants