Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geographiclib: fix cmake name + add topics + del fPIC option if shared #2349

Merged
merged 3 commits into from Aug 12, 2020

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jul 31, 2020

Specify library name and version: geographiclib/all

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

This PR requires conan 1.28.0

@conan-center-bot
Copy link
Collaborator

Some configurations of 'geographiclib/1.50.1' failed in build 1 (c58517c88560419b21e47c7bdd424b2fe2466b20):

@@ -1,9 +1,12 @@
from conans import ConanFile, CMake, tools
import os

required_conan_version = ">=1.28.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I apply this to recipes that require 1.26 features? This feature is absolutely priceless. Can there be a hook for this?!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course! But it only works for Conan >=1.28.0. If you use with an older version, Conan will ignore it. However, it's supported in conan.conf since 1.27 (conan-io/conan#7183), but it's global.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A hook won't be used, we think we should not force this feature, we want to see the community adherence first. If in the future we see more and more people we can add a hook, or course.

@SpaceIm SpaceIm closed this Aug 12, 2020
@SpaceIm SpaceIm reopened this Aug 12, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 2 (c58517c88560419b21e47c7bdd424b2fe2466b20)! 😊

@danimtb danimtb merged commit b0080d6 into conan-io:master Aug 12, 2020
@SpaceIm SpaceIm deleted the fix/geographiclib-cmake-name branch August 12, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants