New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
geographiclib: fix cmake name + add topics + del fPIC option if shared #2349
geographiclib: fix cmake name + add topics + del fPIC option if shared #2349
Conversation
Some configurations of 'geographiclib/1.50.1' failed in build 1 (
|
@@ -1,9 +1,12 @@ | |||
from conans import ConanFile, CMake, tools | |||
import os | |||
|
|||
required_conan_version = ">=1.28.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can I apply this to recipes that require 1.26 features? This feature is absolutely priceless. Can there be a hook for this?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course! But it only works for Conan >=1.28.0. If you use with an older version, Conan will ignore it. However, it's supported in conan.conf since 1.27 (conan-io/conan#7183), but it's global.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A hook won't be used, we think we should not force this feature, we want to see the community adherence first. If in the future we see more and more people we can add a hook, or course.
All green in build 2 (
|
Specify library name and version: geographiclib/all
conan-center hook activated.
This PR requires conan 1.28.0