Add ICU 75.1 #23646

datalogics-staylor · 2024-04-18T15:38:37Z

ICU version 75.1 was just released.

I've read the contributing guidelines.
I've used a recent Conan client version close to the currently deployed.
I've tried at least one configuration locally with the conan-center hook activated.

CLAassistant · 2024-04-18T15:38:46Z

All committers have signed the CLA.

jwillikers

I'm curious whether we need the mingw patch or not for this release.

recipes/icu/all/conandata.yml

jwillikers · 2024-04-22T17:27:02Z

According to the release announcement:

C++ code now requires C++17 and is being made more robust.

Looks like that constraint will need to be enforced for version 75 and later. You should be able to pull the logic from the Qt 6 recipe to require this in the validate method.

datalogics-staylor · 2024-04-22T18:34:59Z

According to the release announcement:

C++ code now requires C++17 and is being made more robust.

Looks like that constraint will need to be enforced for version 75 and later. You should be able to pull the logic from the Qt 6 recipe to require this in the validate method.

Makes sense. Thanks and I will do that!

recipes/icu/all/conanfile.py

jwillikers · 2024-04-25T16:51:47Z

Looks like it is just breaking on the test_package now, but only for Conan V1.

datalogics-staylor · 2024-04-25T19:26:47Z

Looks like it is just breaking on the test_package now, but only for Conan V1.

Yes, I've been trying to figure out what to do about those failures and I'm afraid I'm coming up short.

jwillikers

@datalogics-staylor The issue is due to the test_package not having a C++ standard set when being built with Conan V1. You need to add target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17) to the CMakeLists.txt in the test_package if the version of ICU is greater 75 or later.

Something like the following will probably work.

if (ICU_VERSION VERSION_GREATER_EQUAL "75")
    target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_17)
else()
    target_compile_features(${PROJECT_NAME} PRIVATE cxx_std_11)
endif()

jwillikers · 2024-04-30T12:42:22Z

recipes/icu/all/conanfile.py

+            "msvc": "192",
+            "gcc": "8",
+            "clang": "9",
+            "apple-clang": "12" if Version(self.version) >= "6.5.0" else "11"


This just needs adapted from the Qt 6 recipe.

Suggested change

"apple-clang": "12" if Version(self.version) >= "6.5.0" else "11"

"apple-clang": "11"

Thank you so much! This makes perfect sense now that I understand what went wrong. I was having trouble understanding what the difference from Conan 1 to Conan 2 causing this was from just the logs.

jwillikers · 2024-05-01T13:10:23Z

MSVC isn't using the C++17 standard:

note: 'auto' in non-type template parameters requires at least '/std:c++17'

@RubenRBS What's the best way to go about this?

conan-center-bot · 2024-05-16T15:46:28Z

Conan v1 pipeline ❌

Failure in build 21 (6d909d376b218eb0c717ba21dfe8b36978d3f673):

icu/75.1:
CI failed to create some packages (All logs)

Logs for packageID 4e4e255a893b95913d3edbc4cb2131034a719481:

[settings]
arch=x86_64
build_type=Release
compiler=Visual Studio
compiler.runtime=MD
compiler.version=16
os=Windows
[options]
icu:shared=False

[...]
Creating /dev/mqueue directory failed.
POSIX message queues will not work

cd ./config; \
	make -f pkgdataMakefile
rebuilding config/icucross.inc
rebuilding config/icucross.mk
rm -rf config/icu-config
/usr/bin/install -c /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/icu-config-top config/icu-config
make[1]: Entering directory '/c/J/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/build-release/config'
rm -rf pkgdata.inc
chmod u+w config/icu-config
/bin/sh /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/mkinstalldirs lib
/bin/sh /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/mkinstalldirs bin
mkdir lib
mkdir bin
LC_ALL=C /c/j/workspace/prod-v1/bsr/44078/bcbab/s/fb8319/1/bin/msys64/usr/bin/sed -f /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/make2sh.sed < ./config/Makefile.inc | grep -v '#M#' | uniq >> config/icu-config
make[0]: Making `all' in `stubdata'
make[1]: Entering directory '/c/J/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/build-release/stubdata'
config/icu-i18n.pc updated.
LC_ALL=C /c/j/workspace/prod-v1/bsr/44078/bcbab/s/fb8319/1/bin/msys64/usr/bin/sed -f /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/make2sh.sed < /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/mh-msys-msvc | grep -v '#M#' | uniq >> config/icu-config
config/icu-uc.pc updated.
config/icu-io.pc updated.
generating dependency information for /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/stubdata/stubdata.cpp
cat /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/icu-config-bottom >> config/icu-config
cl -nologo -DNDEBUG -DU_STATIC_IMPLEMENTATION   -DHAVE_DLOPEN=0 -DU_HAVE_MMAP=0 -DU_HAVE_DIRENT_H=0 -DU_HAVE_POPEN=0 -DU_HAVE_TZNAME=0 -DU_HAVE_STRTOD_L=0 -DU_HAVE_WCSCPY=0  -DU_STATIC_IMPLEMENTATION -DU_RELEASE=1 -D_CRT_SECURE_NO_DEPRECATE -I/c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/common  -DU_ALL_IMPLEMENTATION -DU_ATTRIBUTE_DEPRECATED= -DWIN32 -DCYGWINMSVC -MD -O2 -Ob2 -FS   -GF -nologo -EHsc -Zc:wchar_t -utf-8 -c   -Fostubdata.ao /c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/stubdata/stubdata.cpp
stubdata.cpp
chmod u-w config/icu-config
C:/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/common\unicode/localpointer.h(561): error C3533: a parameter cannot have a type that contains 'auto'
C:/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/common\unicode/localpointer.h(561): note: 'auto' in non-type template parameters requires at least '/std:c++17'
C:/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/common\unicode/udata.h(434): error C2975: 'closeFunction': invalid template argument for 'icu_75::internal::LocalOpenPointer', expected compile-time constant expression
C:/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/common\unicode/localpointer.h(561): note: see declaration of 'closeFunction'
make[1]: Leaving directory '/c/J/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/build-release/config'
Note: rebuild with "make VERBOSE=1 " to show all compiler parameters.
make[1]: Leaving directory '/c/J/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/build-release/stubdata'
icu/75.1: 
mkdir: cannot create directory '/dev/shm': Read-only file system
mkdir: cannot create directory '/dev/mqueue': Read-only file system
mkdir: cannot create directory '/dev/shm': Read-only file system
mkdir: cannot create directory '/dev/mqueue': Read-only file system
make[1]: *** [/c/j/workspace/prod-v1/bsr/44078/bcbab/.conan/data/icu/75.1/_/_/build/4e4e255a893b95913d3edbc4cb2131034a719481/src/source/config/mh-msys-msvc:140: stubdata.ao] Error 2
make: *** [Makefile:153: all-recursive] Error 2
WARN: *** Conan 1 is legacy and on a deprecation path ***
WARN: *** Please upgrade to Conan 2 ***
icu/75.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
icu/75.1: ERROR: Package '4e4e255a893b95913d3edbc4cb2131034a719481' build failed
icu/75.1: WARN: Build folder C:\J\workspace\prod-v1\bsr\44078\bcbab\.conan\data\icu\75.1\_\_\build\4e4e255a893b95913d3edbc4cb2131034a719481\build-release
ERROR: icu/75.1: Error in build() method, line 223
	autotools.make()
	ConanException: Error 2 while executing make -j8

icu/74.2:
All packages built successfully! (All logs)
icu/74.1:
Didn't run or was cancelled before finishing
icu/73.2:
Didn't run or was cancelled before finishing
icu/73.1:
Didn't run or was cancelled before finishing
icu/71.1:
Didn't run or was cancelled before finishing
icu/69.1:
Didn't run or was cancelled before finishing
icu/72.1:
Didn't run or was cancelled before finishing
icu/70.1:
Didn't run or was cancelled before finishing
icu/68.2:
All packages built successfully! (All logs)

^{Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.}

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 21 (6d909d376b218eb0c717ba21dfe8b36978d3f673):

icu/74.1:
All packages built successfully! (All logs)
icu/74.2:
All packages built successfully! (All logs)
icu/75.1:
All packages built successfully! (All logs)
icu/73.2:
All packages built successfully! (All logs)
icu/73.1:
All packages built successfully! (All logs)
icu/72.1:
All packages built successfully! (All logs)
icu/68.2:
All packages built successfully! (All logs)
icu/71.1:
All packages built successfully! (All logs)
icu/69.1:
All packages built successfully! (All logs)
icu/70.1:
All packages built successfully! (All logs)

datalogics-staylor mentioned this pull request Apr 18, 2024

[!!] Access request #4

Open

conan-center-bot added the User-approval pending label Apr 18, 2024

This comment has been minimized.

Sign in to view

prince-chrismc mentioned this pull request Apr 18, 2024

Pull Requests Ready to be Reviewed prince-chrismc/conan-center-index-pending-review#1

Open

jwillikers reviewed Apr 22, 2024

View reviewed changes

jwillikers suggested changes Apr 22, 2024

View reviewed changes

recipes/icu/all/conandata.yml Outdated Show resolved Hide resolved

jwillikers approved these changes Apr 22, 2024

View reviewed changes

conan-center-bot added Failed and removed User-approval pending labels Apr 22, 2024

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from 6c2ff9c to 1452c20 Compare April 22, 2024 21:39

jwillikers reviewed Apr 22, 2024

View reviewed changes

recipes/icu/all/conanfile.py Show resolved Hide resolved

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from 09668a1 to 11c4e35 Compare April 23, 2024 15:25

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from d6f3da4 to 8ec4f04 Compare April 25, 2024 14:30

This comment has been minimized.

Sign in to view

conan-center-bot added the Unexpected Error label Apr 25, 2024

This comment has been minimized.

Sign in to view

conan-center-bot removed the Unexpected Error label Apr 25, 2024

This comment has been minimized.

Sign in to view

jwillikers suggested changes Apr 30, 2024

View reviewed changes

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from 55ee9a6 to 61759f9 Compare April 30, 2024 19:57

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from 61759f9 to 031e325 Compare April 30, 2024 20:34

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch 2 times, most recently from 961ed3a to 545a060 Compare April 30, 2024 22:07

This comment has been minimized.

Sign in to view

datalogics-staylor force-pushed the icu-75.1 branch from 6ec5157 to ff1b4df Compare April 30, 2024 23:22

This comment has been minimized.

Sign in to view

datalogics-staylor added 11 commits May 16, 2024 09:37

Add ICU 75.1

fcb5a7f

Carry mingw patch forward

6764b6c

Remove extra characters

297e634

Require a minimum of CPP 17

43387b2

Add minimum compiler check for cpp 17 compatibility

3b6cc5d

Import check_min_cppstd

28cf02d

Simplify minimum cpp check

4c7cebc

Re-add minum compiler version check

2512ea9

Set apple-clang to version 11

8cb1860

Use C++11 in versions earlier than 75.1

31cce04

Use c++ 11 with older ICU in test_v1_package

6d909d3

datalogics-staylor force-pushed the icu-75.1 branch from ff1b4df to 6d909d3 Compare May 16, 2024 14:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add ICU 75.1 #23646

Add ICU 75.1 #23646

datalogics-staylor commented Apr 18, 2024 •

edited

CLAassistant commented Apr 18, 2024 •

edited

This comment has been minimized.

This comment has been minimized.

jwillikers left a comment

This comment has been minimized.

jwillikers commented Apr 22, 2024

datalogics-staylor commented Apr 22, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jwillikers commented Apr 25, 2024 •

edited

datalogics-staylor commented Apr 25, 2024

jwillikers left a comment •

edited

jwillikers Apr 30, 2024

datalogics-staylor Apr 30, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jwillikers commented May 1, 2024

conan-center-bot commented May 16, 2024

	"apple-clang": "12" if Version(self.version) >= "6.5.0" else "11"
	"apple-clang": "11"

Add ICU 75.1 #23646

Are you sure you want to change the base?

Add ICU 75.1 #23646

Conversation

datalogics-staylor commented Apr 18, 2024 • edited

CLAassistant commented Apr 18, 2024 • edited

This comment has been minimized.

This comment has been minimized.

jwillikers left a comment

Choose a reason for hiding this comment

This comment has been minimized.

jwillikers commented Apr 22, 2024

datalogics-staylor commented Apr 22, 2024

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jwillikers commented Apr 25, 2024 • edited

datalogics-staylor commented Apr 25, 2024

jwillikers left a comment • edited

Choose a reason for hiding this comment

jwillikers Apr 30, 2024

Choose a reason for hiding this comment

datalogics-staylor Apr 30, 2024

Choose a reason for hiding this comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

jwillikers commented May 1, 2024

conan-center-bot commented May 16, 2024

Conan v1 pipeline ❌

Conan v2 pipeline ✔️

datalogics-staylor commented Apr 18, 2024 •

edited

CLAassistant commented Apr 18, 2024 •

edited

jwillikers commented Apr 25, 2024 •

edited

jwillikers left a comment •

edited