add microsoft/bond 9.0.0 #2379

yelu · 2020-08-03T08:19:25Z

Specify library name and version: lib/1.0

I've read the guidelines for contributing.
I've followed the PEP8 style guides for Python code in the recipes.
I've used the latest Conan client version.
I've tried at least one configuration locally with the
conan-center hook activated.

CLAassistant · 2020-08-03T08:19:29Z

All committers have signed the CLA.

conan-center-bot · 2020-08-03T08:24:43Z

Failure in build 2 (a46e36bf4e8d50e3d758a0dc3dd2d5e20982737e):
bond/9.0.0:

Error processing recipe: Linux x86_64, Release, gcc 5, libstdc++ . Options: bond:shared-True
Unexpected error happened:

ERROR: bond/9.0.0: 'True' is not a valid 'options.shared' value.
Possible values are ['False']

conan-center-bot · 2020-08-03T08:37:53Z

Some configurations of 'bond/9.0.0' failed in build 4 (e535502cd1aa23d7e5ef09e7e0e7df8aa4fddf17):

Linux x86_64, Release, gcc 5, libstdc++ . Options: bond:shared-True
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_export(): ERROR: [RECIPE METADATA (KB-H003)] Conanfile doesn't have 'homepage' attribute. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H003)
  - [HOOK - conan-center.py] pre_export(): ERROR: [CONAN CENTER INDEX URL (KB-H027)] The attribute 'url' should point to: https://github.com/conan-io/conan-center-index (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H027)
  - [HOOK - conan-center.py] pre_export(): ERROR: [TEST PACKAGE - NO IMPORTS() (KB-H034)] The method importsis not allowed in test_package/conanfile.py (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H034)
  - [HOOK - conan-center.py] pre_export(): ERROR: [NO AUTHOR (KB-H037)] Conanfile should not contain author. Remove 'author = "Lu Ye luye@microsoft.com"' (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H037)
- Log download
- Log error Download
- Profile
Access to all the logs

conan-center-bot · 2020-08-03T09:24:22Z

Some configurations of 'bond/9.0.0' failed in build 5 (01f578c194e117b4d3e8138384c997a83d29367a):

Linux x86_64, Release, gcc 5, libstdc++ . Options: bond:shared-True
You are depending on 'boost/1.71.0@conan/stable' but it is not in the repository

madebr · 2020-08-03T12:02:47Z

recipes/bond/all/conanfile.py

+    def source(self):
+        self.run("git clone https://github.com/microsoft/bond.git")
+        self.run("git checkout fe6f582ce4beb65644d9338536066e07d80a0289", cwd='bond')
+        self.run("git submodule update --init --recursive", cwd='bond')
+        tools.replace_in_file("bond/CMakeLists.txt",
+                              "project (bond)",
+                              '''project (bond)
+message("BOOST_ROOT=$ENV{BOOST_ROOT}")''')


Can you please package release 9.0.1: https://github.com/microsoft/bond/releases/tag/9.0.1
Then, you can use conandata.yml + export_source a CMakeLists.txt file, as all other recipes do.

madebr · 2020-08-03T12:03:40Z

recipes/bond/all/conanfile.py

+    default_options = {
+        "shared": False,
+        "fPIC": True}
+    build_requires = "boost/1.71.0@conan/stable"


Suggested change

build_requires = "boost/1.71.0@conan/stable"

requires = "boost/1.73..0"

A require is really necessary.
If boost is shared, then the library must be installed too.

madebr · 2020-08-03T12:04:34Z

recipes/bond/all/conanfile.py

+        self.cpp_info.includedirs = ['include']
+        self.cpp_info.libdirs = ['lib/bond']


Isn't the library installed in the lib folder?

Suggested change

self.cpp_info.includedirs = ['include']

self.cpp_info.libdirs = ['lib/bond']

self.cpp_info.libdirs.append(os.path.join("lib", "bond"))

madebr · 2020-08-03T12:05:21Z

recipes/bond/all/test_package/CMakeLists.txt

+target_link_libraries(example ${CONAN_LIBS})
+
+# CTest is a testing tool that can be used to test your project.
+# enable_testing()
+# add_test(NAME example
+#          WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin
+#          COMMAND example)


Suggested change

target_link_libraries(example ${CONAN_LIBS})

# CTest is a testing tool that can be used to test your project.

# enable_testing()

# add_test(NAME example

# WORKING_DIRECTORY ${CMAKE_BINARY_DIR}/bin

# COMMAND example)

target_link_libraries(example ${CONAN_LIBS})

madebr · 2020-08-03T12:05:34Z

recipes/bond/all/test_package/conanfile.py

+        # Current dir is "test_package/build/<build_id>" and CMakeLists.txt is
+        # in "test_package"


Suggested change

# Current dir is "test_package/build/<build_id>" and CMakeLists.txt is

# in "test_package"

madebr · 2020-08-03T12:06:10Z

recipes/bond/all/test_package/conanfile.py

+        if not tools.cross_building(self):
+            os.chdir("bin")
+            self.run(".%sexample" % os.sep)


Suggested change

if not tools.cross_building(self):

os.chdir("bin")

self.run(".%sexample" % os.sep)

if not tools.cross_building(self.settings):

bin_path = os.path.join("bin", "example")

self.run(bin_path, run_environment=True)

madebr · 2020-08-03T12:07:05Z

recipes/bond/all/test_package/example.cpp

+#include <bond/core/bond_const_enum.h>
+
+int main() {
+    std::cout << "bond is installed successfully" << std::endl;


Please call at least one bond function (not using a define or header-only function).
That way we can be sure the library is tested properly.

madebr · 2020-08-03T12:08:37Z

recipes/bond/all/conanfile.py

+        "fPIC": True}
+    build_requires = "boost/1.71.0@conan/stable"
+    generators = "cmake"
+    exports_sources = ["FindBond.cmake"]


Please remove this file (and export a conan wrapper CMakeLists.txt file instead).

As a consumer of this recipe, when using the cmake_find_package generator, conan will genere a FindBond.cmake script automatically.

madebr · 2020-08-03T12:09:30Z

recipes/bond/all/conanfile.py

+            self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')
+        self.copy("FindBond.cmake", ".", ".")
+
+    def package_info(self):


Apply this change only if bond creates BondConfig.cmake or FindBond.cmake files.

Suggested change

def package_info(self):

def package_info(self):

self.cpp_info.names["cmake_find_package"] = "Bond"

self.cpp_info.names["cmake_find_package_multi"] = "Bond"

conan-center-bot · 2020-08-04T10:04:11Z

Some configurations of 'bond/9.0.0' failed in build 6 (8866aeeb76b00e0ecafe512f3101de29442a7679):

Linux x86_64, Release, gcc 5, libstdc++
- Hooks errors detected:
  - [HOOK - conan-center.py] pre_source(): ERROR: [IMMUTABLE SOURCES (KB-H010)] Create a file 'conandata.yml' file with the sources to be downloaded. (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H010)
- Log download
- Log error Download
- Profile
Access to all the logs

uilianries · 2020-08-04T20:53:08Z

recipes/bond/all/FindBond.cmake

@@ -0,0 +1,9 @@
+# find_path(BOND_INCLUDE_DIR NAMES bond PATHS ${CONAN_INCLUDE_DIRS_BOND})


Please, remove this file. Conan should be able to generate the file by https://docs.conan.io/en/latest/integrations/build_system/cmake/cmake_find_package_generator.html

uilianries · 2020-08-04T20:53:53Z

recipes/bond/all/conanfile.py

+
+class BondConan(ConanFile):
+    name = "bond"
+    version = "9.0.0"


Suggested change

version = "9.0.0"

The version should be consumed from conandata.yml: https://docs.conan.io/en/latest/reference/config_files/conandata.yml.html

uilianries · 2020-08-04T20:54:34Z

recipes/bond/all/conanfile.py

+class BondConan(ConanFile):
+    name = "bond"
+    version = "9.0.0"
+    license = "MIT License"


Suggested change

license = "MIT License"

license = "MIT"

Use the short-name form https://spdx.org/licenses/MIT

uilianries · 2020-08-04T20:54:47Z

recipes/bond/all/conanfile.py

+    name = "bond"
+    version = "9.0.0"
+    license = "MIT License"
+    homepage = "https://github.com/microsoft/bond.git"


Suggested change

homepage = "https://github.com/microsoft/bond.git"

homepage = "https://github.com/microsoft/bond"

uilianries · 2020-08-04T20:55:47Z

recipes/bond/all/conanfile.py

+    homepage = "https://github.com/microsoft/bond.git"
+    url = "https://github.com/conan-io/conan-center-index"
+    description = "Bond is a cross-platform framework for working with schematized data. It supports cross-language de/serialization and powerful generic mechanisms for efficiently manipulating data. Bond is broadly used at Microsoft in high scale services."
+    topics = ("bond", "microsoft")


Suggested change

topics = ("bond", "microsoft")

topics = ("bond", "microsoft", "serialization", "cross-language", "schematized-data")

uilianries · 2020-08-04T21:01:50Z

recipes/bond/all/conanfile.py

+
+    def configure_cmake(self):
+        if platform.system() == "Linux":
+            self.run("curl -sSL https://get.haskellstack.org/ | sh", ignore_errors=True)


Why do you need haskell? Downloading here is not allowed, but instead you can have a Conan package for haskell.

uilianries · 2020-08-04T21:02:52Z

recipes/bond/all/conanfile.py

+        cmake.install()
+        if platform.system() == 'Linux':
+            self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')
+        self.copy("FindBond.cmake", ".", ".")


Suggested change

self.copy("FindBond.cmake", ".", ".")

Not allowed. Use cmake_find_package generator instead.

uilianries · 2020-08-04T21:05:35Z

recipes/bond/all/conanfile.py

+        if platform.system() == 'Linux':
+            self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')


Suggested change

if platform.system() == 'Linux':

self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')

if tools.os_info.is_linux:

self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')

Use os.chmod instead. Is there an executable here?

uilianries · 2020-08-04T21:09:08Z

recipes/bond/all/conanfile.py

+    def package_info(self):
+        self.cpp_info.includedirs = ['include']
+        self.cpp_info.libdirs = ['lib/bond']
+        self.cpp_info.libs = ["bond"]


Suggested change

self.cpp_info.libs = ["bond"]

self.cpp_info.libs = ["bond"]

self.cpp_info.builddirs.append(os.path.join("lib", "cmake", "bond"))

self.cpp_info.build_modules.append(os.path.join("lib", "cmake", "bond", "Bond.cmake"))

The cmake file offered by author contains some macros. Conan can't re-create it, so the best approach is copying it to your package.

https://github.com/microsoft/bond/blob/master/cmake/Bond.cmake

uilianries · 2020-08-04T21:11:24Z

recipes/bond/all/conanfile.py

+        cmake = self.configure_cmake()
+        cmake.build()
+
+    def package(self):


Suggested change

def package(self):

def package(self):

self.copy("LICENSE", dst="licenses", src="bond")

self.copy("Bond.cmake", dst=os.path.join("lib", "cmake", "bond"), src=os.path.join("bond", "cmake))

Don't forget the license
Bond.cmake seems be useful.

stale · 2020-12-01T13:41:04Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale · 2020-12-31T14:24:03Z

This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions.

add microsoft/bond 9.0.0

a6f0f3a

add microsoft/bond 9.0.0

a46e36b

conan-center-bot added the Failed label Aug 3, 2020

yelu added 2 commits August 3, 2020 16:29

all shared and static

8edaa95

all shared and static

e535502

fix hooks errors

01f578c

madebr reviewed Aug 3, 2020

View reviewed changes

fix boost deps errors

8866aee

uilianries requested changes Aug 4, 2020

View reviewed changes

SpaceIm mentioned this pull request Aug 26, 2020

[request] some of most relevant c++ libraries in github (by number of stars) #621

Open

stale bot added the stale label Dec 1, 2020

stale bot closed this Dec 31, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add microsoft/bond 9.0.0 #2379

add microsoft/bond 9.0.0 #2379

yelu commented Aug 3, 2020

CLAassistant commented Aug 3, 2020 •

edited

Loading

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 3, 2020

madebr Aug 3, 2020 •

edited

Loading

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

madebr Aug 3, 2020

conan-center-bot commented Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

uilianries Aug 4, 2020

stale bot commented Dec 1, 2020

stale bot commented Dec 31, 2020

	build_requires = "boost/1.71.0@conan/stable"
	requires = "boost/1.73..0"

		self.cpp_info.includedirs = ['include']
		self.cpp_info.libdirs = ['lib/bond']

	self.cpp_info.includedirs = ['include']
	self.cpp_info.libdirs = ['lib/bond']
	self.cpp_info.libdirs.append(os.path.join("lib", "bond"))

		# Current dir is "test_package/build/<build_id>" and CMakeLists.txt is
		# in "test_package"

		@@ -0,0 +1,9 @@
		# find_path(BOND_INCLUDE_DIR NAMES bond PATHS ${CONAN_INCLUDE_DIRS_BOND})

	homepage = "https://github.com/microsoft/bond.git"
	homepage = "https://github.com/microsoft/bond"

	topics = ("bond", "microsoft")
	topics = ("bond", "microsoft", "serialization", "cross-language", "schematized-data")

		if platform.system() == 'Linux':
		self.run("chmod +rx *", cwd=f'{self.package_folder}/bin')

add microsoft/bond 9.0.0 #2379

add microsoft/bond 9.0.0 #2379

Conversation

yelu commented Aug 3, 2020

CLAassistant commented Aug 3, 2020 • edited Loading

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 3, 2020

conan-center-bot commented Aug 3, 2020

madebr Aug 3, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

conan-center-bot commented Aug 4, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

stale bot commented Dec 1, 2020

stale bot commented Dec 31, 2020

CLAassistant commented Aug 3, 2020 •

edited

Loading

madebr Aug 3, 2020 •

edited

Loading