Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rapidyaml: add version 0.7.0 #23837

Merged
merged 4 commits into from
Jun 17, 2024
Merged

rapidyaml: add version 0.7.0 #23837

merged 4 commits into from
Jun 17, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented May 1, 2024 •
edited

Specify library name and version: rapidyaml/0.7.0

biojppm/rapidyaml@v0.5.0...v0.7.0

@prince-chrismc prince-chrismc mentioned this pull request May 1, 2024
Open
@conan-center-bot

This comment has been minimized.

Sign in to view
This was referenced May 1, 2024
Open
Open
@ericLemanissier ericLemanissier mentioned this pull request May 1, 2024
Closed
RubenRBS
RubenRBS reviewed May 4, 2024
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Thanks a lot :)

Minor comment about the handling of the new option, otherwise looks good

recipes/rapidyaml/all/conanfile.py
}
default_options = {
"shared": False,
"fPIC": True,
"with_default_callbacks": True,
"with_tab_tokens": False,
"with_default_callback_uses_exceptions": False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Afaik this one should only be valid if with_default_callbacks is true as per biojppm/rapidyaml@v0.5.0...v0.6.0#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR17-R19 - we might need to delete the option in configure if that is true

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RubenRBS
Sorry for late resposne.
I fixed it.

@RubenRBS RubenRBS self-assigned this May 4, 2024
@toge toge changed the title rapidyaml: add version 0.6.0 rapidyaml: add version 0.7.0 Jun 14, 2024
RubenRBS
RubenRBS approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@RubenRBS RubenRBS left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! No worries about the late response at all :)

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 4 (9576c44ca5a4efea8b6b55663d5c7d4b4b740bfd):

  • rapidyaml/0.5.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.4.1:
    All packages built successfully! (All logs)

  • rapidyaml/0.4.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.7.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.3.0:
    All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 4 (9576c44ca5a4efea8b6b55663d5c7d4b4b740bfd):

  • rapidyaml/0.7.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.5.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.4.1:
    All packages built successfully! (All logs)

  • rapidyaml/0.4.0:
    All packages built successfully! (All logs)

  • rapidyaml/0.3.0:
    All packages built successfully! (All logs)

uilianries
uilianries approved these changes Jun 17, 2024
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM biojppm/rapidyaml@v0.5.0...v0.7.0

@conan-center-bot conan-center-bot merged commit 5a5a263 into conan-io:master Jun 17, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uilianries uilianries uilianries approved these changes

@RubenRBS RubenRBS RubenRBS approved these changes

Assignees

@RubenRBS RubenRBS

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@toge @conan-center-bot @uilianries @RubenRBS