-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added open62541 v1.4.1 #23882
base: master
Are you sure you want to change the base?
Added open62541 v1.4.1 #23882
Conversation
- Removed open62541 v1.3.8 - Added open62541 v1.4.0
This comment has been minimized.
This comment has been minimized.
@RubenRBS There is nothing I can really do about this, can I? How should I proceed? |
@conan-io/barbarians How should I proceed with this PR? |
@Kischy Thank you for your contribution! That message related to conflicts should be ignored, it's an external project that checks for PRs changing the same recipe. About your current error, it's a compilation error, it looks be related to this new version 1.4.0:
It looks be a bug from the upstream, reported already: open62541/open62541#5178 If it's the case, we can not fix the upstream code, needs an official answer for this. In case the upstream provides a hotfix, you can apply it as a patch, or use a new patch version in case released by the upstream. |
@uilianries Thank you so much, I did not check the output. I wrongly assumed that the conflict is the reason for the failure! My bad! |
Ok, I will have a look in the original repo. In this case we might skip this version. I would keep this PR open until it is fixed. Or do you want a new PR after the fix of open62541/open62541#5178 ? |
@Kischy No problem!
As you are adding only 1.4.0, you can keep it open, so more will be aware about PR bumping that version. Thank you for checking the upstream code. I saw a bunch of PR opened there, but I didn't check if some of them is related to the current error. |
@uilianries |
@uilianries |
Conan v1 pipeline ❌Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Hello, I think the 0001-disable-sanitizers-1_4_x.patch is for CMakeLists v1.4.0 it should be updated for v1.4.1 CMakeLists |
Thank you for bringing this up. I was pobably to lazy when doing the switch from 1.4.0 to 1.4.1. I currently do not have the time to work on this. With 1.4.0 there was a problem in the CMake Setup of the upstream repo in comparission to previous versions, which made the build fail. I might have time in a month to look at this. In the meantime I am happy for anyone who helps :) |
Added open62541 v1.4.0Specify library name and version: open62541/v1.4.0