Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added open62541 v1.4.1 #23882

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

Kischy
Copy link
Contributor

@Kischy Kischy commented May 6, 2024

  • Removed open62541 v1.3.8
  • Added open62541 v1.4.0
  • Added open62541 v1.4.1

Specify library name and version: open62541/v1.4.0


@conan-center-bot

This comment has been minimized.

@Kischy
Copy link
Contributor Author

Kischy commented May 6, 2024

I detected other pull requests that are modifying open62541/all recipe:

* [refactor: open62541 test_package #23745](https://github.com/conan-io/conan-center-index/pull/23745)

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@RubenRBS There is nothing I can really do about this, can I? How should I proceed?

@Kischy
Copy link
Contributor Author

Kischy commented May 21, 2024

@conan-io/barbarians How should I proceed with this PR?

@uilianries
Copy link
Member

@Kischy Thank you for your contribution!

That message related to conflicts should be ignored, it's an external project that checks for PRs changing the same recipe.

About your current error, it's a compilation error, it looks be related to this new version 1.4.0:

https://c3i.jfrog.io/c3i/misc-v2/summary.html?json=https://c3i.jfrog.io/c3i/misc-v2/logs/pr/23882/2-linux-gcc/open62541/1.4.0//summary.json

[ 39%] Building C object CMakeFiles/open62541-object.dir/src/server/ua_server_ns0_diagnostics.c.o
/home/conan/workspace/prod-v2/bsr/34247/cadec/p/b/open6ded8e059b2eb1/b/src/src/server/ua_server_ns0.c: In function 'initNS0':
/home/conan/workspace/prod-v2/bsr/34247/cadec/p/b/open6ded8e059b2eb1/b/src/src/server/ua_server_ns0.c:1050:45: error: 'UA_NS0ID_SERVER_SERVERCAPABILITIES_CONFORMANCEUNITS' undeclared (first use in this function); did you mean 'UA_NS0ID_SERVER_SERVERCAPABILITIES_MAXARRAYLENGTH'?
 1050 |     deleteNode(server, UA_NODEID_NUMERIC(0, UA_NS0ID_SERVER_SERVERCAPABILITIES_CONFORMANCEUNITS), true);
      |                                             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                             UA_NS0ID_SERVER_SERVERCAPABILITIES_MAXARRAYLENGTH

It looks be a bug from the upstream, reported already: open62541/open62541#5178

If it's the case, we can not fix the upstream code, needs an official answer for this. In case the upstream provides a hotfix, you can apply it as a patch, or use a new patch version in case released by the upstream.

@uilianries uilianries self-assigned this May 21, 2024
@Kischy
Copy link
Contributor Author

Kischy commented May 21, 2024

@uilianries Thank you so much, I did not check the output. I wrongly assumed that the conflict is the reason for the failure! My bad!

@Kischy
Copy link
Contributor Author

Kischy commented May 21, 2024

@uilianries

About your current error, it's a compilation error, it looks be related to this new version 1.4.0:

Ok, I will have a look in the original repo. In this case we might skip this version. I would keep this PR open until it is fixed. Or do you want a new PR after the fix of open62541/open62541#5178 ?

@uilianries
Copy link
Member

I wrongly assumed that the conflict is the reason for the failure! My bad!

@Kischy No problem!

Ok, I will have a look in the original repo. In this case we might skip this version. I would keep this PR open until it is fixed. Or do you want a new PR after the fix of open62541/open62541#5178 ?

As you are adding only 1.4.0, you can keep it open, so more will be aware about PR bumping that version.

Thank you for checking the upstream code. I saw a bunch of PR opened there, but I didn't check if some of them is related to the current error.

@Kischy
Copy link
Contributor Author

Kischy commented May 21, 2024

I wrongly assumed that the conflict is the reason for the failure! My bad!

@Kischy No problem!

Ok, I will have a look in the original repo. In this case we might skip this version. I would keep this PR open until it is fixed. Or do you want a new PR after the fix of open62541/open62541#5178 ?

As you are adding only 1.4.0, you can keep it open, so more will be aware about PR bumping that version.

Thank you for checking the upstream code. I saw a bunch of PR opened there, but I didn't check if some of them is related to the current error.

@uilianries
The original issue has been open for quite some time. The cmake build setup must have changed somehow for this bug to surface now. I will discuss this with a colleague tomorrow if we have the time to fix this here or in the open62541 repo.

@Kischy
Copy link
Contributor Author

Kischy commented May 22, 2024

@uilianries
Unfortunately this is not a priority for us right now. I will not be able to look at this in the near future. I will let you know if this changes

@Kischy Kischy changed the title Added open62541 v1.4.0 Added open62541 v1.4.1 Jun 3, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ❌

Failure in build 3 (d92a80563488bcd4edc82df96401cfa424ec6e35):

  • open62541/1.4.1:
    CI failed to create some packages (All logs)

    Logs for packageID fb10894242ae497baefff1b1fcbc4b5e4da50586:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=gcc
    compiler.libcxx=libstdc++11
    compiler.version=5
    os=Linux
    [options]
    open62541:shared=False
    
    [...]
    [env]
    [conf]
    tools.system.package_manager:mode=install
    tools.system.package_manager:sudo=True
    
    open62541/1.4.1: Forced build from source
    Installing package: open62541/1.4.1
    Requirements
        open62541/1.4.1 from local cache - Cache
    Packages
        open62541/1.4.1:fb10894242ae497baefff1b1fcbc4b5e4da50586 - Build
    
    Installing (downloading, building) binaries...
    [HOOK - conan-center.py] pre_source(): [IMMUTABLE SOURCES (KB-H010)] OK
    open62541/1.4.1: Configuring sources in /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/source/src
    open62541/1.4.1: 
    open62541/1.4.1: 
    open62541/1.4.1: Unzipping 92.5MB, this can take a while
    open62541/1.4.1: 
    [HOOK - conan-center.py] post_source(): [LIBCXX MANAGEMENT (KB-H011)] OK
    [HOOK - conan-center.py] post_source(): [CPPSTD MANAGEMENT (KB-H022)] OK
    [HOOK - conan-center.py] post_source(): [SHORT_PATHS USAGE (KB-H066)] OK
    open62541/1.4.1: Copying sources to build folder
    open62541/1.4.1: Building your package in /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586
    open62541/1.4.1: Generator txt created conanbuildinfo.txt
    open62541/1.4.1: Calling generate()
    open62541/1.4.1: Preset 'release' added to CMakePresets.json. Invoke it manually using 'cmake --preset release'
    open62541/1.4.1: If your CMake version is not compatible with CMakePresets (<3.19) call cmake like: 'cmake <path> -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=/home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/build/Release/generators/conan_toolchain.cmake -DCMAKE_POLICY_DEFAULT_CMP0077=NEW -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_BUILD_TYPE=Release'
    open62541/1.4.1: Aggregating env generators
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK. 'fPIC' option found and apparently well managed
    [HOOK - conan-center.py] pre_build(): [FPIC MANAGEMENT (KB-H007)] OK
    open62541/1.4.1: Calling build()
    open62541/1.4.1: Apply patch (conan): Disable static code analysis
    open62541/1.4.1: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch: source file is different - b'CMakeLists.txt'
    open62541/1.4.1: 
    WARN: *** Conan 1 is legacy and on a deprecation path ***
    WARN: *** Please upgrade to Conan 2 ***
    open62541/1.4.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    open62541/1.4.1: WARN: Using the new toolchains and generators without specifying a build profile (e.g: -pr:b=default) is discouraged and might cause failures and unexpected behavior
    open62541/1.4.1: WARN: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch: file 1/1:	 b'CMakeLists.txt'
    open62541/1.4.1: WARN: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch:  hunk no.1 doesn't match source file at line 650
    open62541/1.4.1: WARN: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch:   expected: b'    # Linker'
    open62541/1.4.1: WARN: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch:   actual  : b'                check_add_cc_flag("-fcf-protection")'
    open62541/1.4.1: ERROR: Package 'fb10894242ae497baefff1b1fcbc4b5e4da50586' build failed
    open62541/1.4.1: WARN: Build folder /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/build/Release
    ERROR: open62541/1.4.1: Error in build() method, line 370
    	self._patch_sources()
    while calling '_patch_sources', line 365
    	apply_conandata_patches(self)
    	ConanException: Failed to apply patch: /home/conan/workspace/prod-v1/bsr/53133/cefec/.conan/data/open62541/1.4.1/_/_/build/fb10894242ae497baefff1b1fcbc4b5e4da50586/patches/0001-disable-sanitizers-1_4_x.patch
    
  • open62541/1.2.6:
    Didn't run or was cancelled before finishing

  • open62541/1.1.6:
    Didn't run or was cancelled before finishing

  • open62541/1.3.9:
    Didn't run or was cancelled before finishing

  • open62541/1.0.6:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@engel-bichlerh
Copy link

Hello, I think the 0001-disable-sanitizers-1_4_x.patch is for CMakeLists v1.4.0 it should be updated for v1.4.1 CMakeLists

@Kischy
Copy link
Contributor Author

Kischy commented Jun 25, 2024

Hello, I think the 0001-disable-sanitizers-1_4_x.patch is for CMakeLists v1.4.0 it should be updated for v1.4.1 CMakeLists

Thank you for bringing this up. I was pobably to lazy when doing the switch from 1.4.0 to 1.4.1. I currently do not have the time to work on this. With 1.4.0 there was a problem in the CMake Setup of the upstream repo in comparission to previous versions, which made the build fail. I might have time in a month to look at this. In the meantime I am happy for anyone who helps :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants