-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
libwebsocket: actually build 4.3.2 and later #23968
libwebsocket: actually build 4.3.2 and later #23968
Conversation
The build is now finished. You can take a look at the results here |
This comment has been minimized.
This comment has been minimized.
Conan v1 pipeline ✔️All green in build 3 (
Conan v2 pipeline ✔️
All green in build 3 (
|
@uilianries @RubenRBS what do you think of this fix ? This is quite urgent because all consumers of libwebsocket >= 4.3.2 fall in ConanInvalidConfiguration exception currently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving after looking into it with @czoido
Thanks ! |
fixes #23967
Specify library name and version: libwebsocket/*
@jcar87 you are the original author of this line, so you probably want to take a look at the fix