Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpdecimal: remove deprecated 'path' functions #23989

Closed

Conversation

juansblanco
Copy link
Contributor

@juansblanco juansblanco commented May 14, 2024

Specify library name and version: mpdecimal

Replace deprecated path functions with the corresponding folder functions.

Follow up to: conan-io/conan#16247


uilianries
uilianries previously approved these changes May 14, 2024
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 3 (c4c6656a3e5f36b98032200b8d539de0cae6fc45):

  • mpdecimal/2.4.2:
    All packages built successfully! (All logs)

  • mpdecimal/2.5.0:
    All packages built successfully! (All logs)

  • mpdecimal/2.5.1:
    All packages built successfully! (All logs)


Conan v2 pipeline ❌

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

The v2 pipeline failed. Please, review the errors and note this is required for pull requests to be merged. In case this recipe is still not ported to Conan 2.x, please, ping @conan-io/barbarians on the PR and we will help you.

See details:

Failure in build 3 (c4c6656a3e5f36b98032200b8d539de0cae6fc45):

  • mpdecimal/2.4.2:
    Didn't run or was cancelled before finishing

  • mpdecimal/2.5.1:
    CI failed to create some packages (All logs)

    Logs for packageID 9f69305d358977042aa4b289c18f45fcf5827ece:
    [settings]
    arch=x86_64
    build_type=Release
    compiler=apple-clang
    compiler.cppstd=17
    compiler.libcxx=libc++
    compiler.version=13
    os=Macos
    [options]
    */*:shared=True
    
    [...]
    mpdecimal/2.5.1 (test package): Calling build()
    mpdecimal/2.5.1 (test package): Running CMake.configure()
    mpdecimal/2.5.1 (test package): RUN: cmake -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE="/Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package/build/apple-clang-13-x86_64-17-release/generators/conan_toolchain.cmake" -DCMAKE_INSTALL_PREFIX="/Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package" -DCMAKE_POLICY_DEFAULT_CMP0091="NEW" -DCMAKE_BUILD_TYPE="Release" "/Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package"
    -- Using Conan toolchain: /Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package/build/apple-clang-13-x86_64-17-release/generators/conan_toolchain.cmake
    -- Conan toolchain: C++ Standard 17 with extensions OFF
    -- The CXX compiler identification is AppleClang 13.0.0.13000029
    -- The C compiler identification is AppleClang 13.0.0.13000029
    -- Detecting CXX compiler ABI info
    -- Detecting CXX compiler ABI info - done
    -- Check for working CXX compiler: /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/c++ - skipped
    -- Detecting CXX compile features
    -- Detecting CXX compile features - done
    -- Detecting C compiler ABI info
    -- Detecting C compiler ABI info - done
    -- Check for working C compiler: /Applications/conan/xcode/13.0/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc - skipped
    -- Detecting C compile features
    -- Detecting C compile features - done
    -- Conan: Component target declared 'mpdecimal::libmpdecimal'
    -- Conan: Component target declared 'mpdecimal::libmpdecimal++'
    -- Conan: Target declared 'mpdecimal::mpdecimal'
    -- Configuring done
    -- Generating done
    -- Build files have been written to: /Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package/build/apple-clang-13-x86_64-17-release
    
    mpdecimal/2.5.1 (test package): Running CMake.build()
    mpdecimal/2.5.1 (test package): RUN: cmake --build "/Users/jenkins/workspace/prod-v2/bsr/cci-c4515318/recipes/mpdecimal/2.5.x/test_package/build/apple-clang-13-x86_64-17-release" -- -j8
    [ 50%] Building CXX object CMakeFiles/test_package_cpp.dir/test_package.cpp.o
    [ 50%] Building C object CMakeFiles/test_package.dir/test_package.c.o
    [ 75%] Linking C executable test_package
    [ 75%] Built target test_package
    [100%] Linking CXX executable test_package_cpp
    ld: warning: ignoring file /Users/jenkins/workspace/prod-v2/bsr/38544/acefa/p/b/mpdecadb9407efcb82/p/lib/libmpdec++.dylib, building for macOS-x86_64 but attempting to link with file built for macOS-arm64
    Undefined symbols for architecture x86_64:
      "decimal::Context::raiseit(unsigned int)", referenced from:
          _main in test_package.cpp.o
          decimal::Decimal::Decimal(char const*) in test_package.cpp.o
      "decimal::operator<<(std::__1::basic_ostream<char, std::__1::char_traits<char>>&, decimal::Decimal const&)", referenced from:
          _main in test_package.cpp.o
      "thread-local wrapper routine for decimal::context", referenced from:
          _main in test_package.cpp.o
          decimal::Decimal::Decimal(char const*) in test_package.cpp.o
    ld: symbol(s) not found for architecture x86_64
    clang: error: linker command failed with exit code 1 (use -v to see invocation)
    make[2]: *** [test_package_cpp] Error 1
    make[1]: *** [CMakeFiles/test_package_cpp.dir/all] Error 2
    make: *** [all] Error 2
    
    ERROR: mpdecimal/2.5.1 (test package): Error in build() method, line 20
    	cmake.build()
    	ConanException: Error 2 while executing
    
  • mpdecimal/2.5.0:
    Didn't run or was cancelled before finishing


Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

@juansblanco
Copy link
Contributor Author

We decided to not start updating the recipes for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants