Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quill: add version 4.3.0 #24070

Merged
merged 11 commits into from
Jun 3, 2024
Merged

quill: add version 4.3.0 #24070

merged 11 commits into from
Jun 3, 2024

Conversation

toge
Copy link
Contributor

@toge toge commented May 22, 2024

Specify library name and version: quill/*

quill/4.3.0 becomes header only library.

odygrd/quill@v3.9.0...v4.3.0


@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@RazielXYZ
Copy link
Contributor

RazielXYZ commented May 23, 2024

Quill 4.0.0 also includes fmt under its own fmtquill namespace, and no longer supports external fmt, so there's no point in requiring fmt or defining QUILL_FMT_EXTERNAL for >=4.0.0

@toge
Copy link
Contributor Author

toge commented May 24, 2024

@RazielXYZ
Thank you for your comment!
I missed it.
Fixed.

@conan-center-bot

This comment has been minimized.

@toge toge changed the title quill: add version 4.0.0 quill: add version 4.1.0 May 26, 2024
@conan-center-bot

This comment has been minimized.

@RubenRBS RubenRBS self-assigned this May 27, 2024
RubenRBS
RubenRBS previously approved these changes May 27, 2024
Copy link
Member

@RubenRBS RubenRBS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @toge - I was going to ask you to split the recipe into two versions to simplify the logic, but I (correctly) guessed it would be quite tedious so I've done it myself to save you some time, let's see if this works :) Thanks a lot!

@conan-center-bot

This comment has been minimized.

@toge
Copy link
Contributor Author

toge commented May 28, 2024

@RubenRBS
Thank you for the improvement!
I was wondering if I should create new recipes for 4.0.0 and you gave me a good direction.

For my recipes, you just need to direct me to the changes.
You are one of the key people in this project and your work time is obviously more valuable than mine.

@odygrd
Copy link
Contributor

odygrd commented May 31, 2024

Hello @toge,

Thank you so much for doing this! I was unsure how to update the recipe for the new version.

The main differences in version v4 are as follows:

  • It is now a header-only library.
  • The CMake option QUILL_FMT_EXTERNAL has been removed.
  • The option QUILL_DISABLE_POSITION_INDEPENDENT_CODE is no longer relevant.

Thanks again!

@toge toge changed the title quill: add version 4.1.0 quill: add version 4.2.1 Jun 1, 2024
@conan-center-bot

This comment has been minimized.

@toge toge changed the title quill: add version 4.2.1 quill: add version 4.3.0 Jun 2, 2024
@conan-center-bot
Copy link
Collaborator

Conan v1 pipeline ✔️

All green in build 12 (93ccfb576614e6438e0208bd0b64b3b980a8f78e):

  • quill/3.9.0:
    All packages built successfully! (All logs)

  • quill/3.8.0:
    All packages built successfully! (All logs)

  • quill/3.7.0:
    All packages built successfully! (All logs)

  • quill/3.3.1:
    All packages built successfully! (All logs)

  • quill/3.0.2:
    All packages built successfully! (All logs)

  • quill/2.9.2:
    All packages built successfully! (All logs)

  • quill/4.3.0:
    All packages built successfully! (All logs)

  • quill/3.4.1:
    All packages built successfully! (All logs)

  • quill/3.6.0:
    All packages built successfully! (All logs)

  • quill/3.4.0:
    All packages built successfully! (All logs)

  • quill/2.7.0:
    All packages built successfully! (All logs)

  • quill/3.5.1:
    All packages built successfully! (All logs)

  • quill/3.5.0:
    All packages built successfully! (All logs)

  • quill/1.7.3:
    All packages built successfully! (All logs)

  • quill/2.9.0:
    All packages built successfully! (All logs)

  • quill/2.9.1:
    All packages built successfully! (All logs)

  • quill/3.2.0:
    All packages built successfully! (All logs)

  • quill/2.8.0:
    All packages built successfully! (All logs)

  • quill/3.1.0:
    All packages built successfully! (All logs)

  • quill/2.6.0:
    All packages built successfully! (All logs)


Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 12 (93ccfb576614e6438e0208bd0b64b3b980a8f78e):

  • quill/3.9.0:
    All packages built successfully! (All logs)

  • quill/3.7.0:
    All packages built successfully! (All logs)

  • quill/3.8.0:
    All packages built successfully! (All logs)

  • quill/3.2.0:
    All packages built successfully! (All logs)

  • quill/4.3.0:
    All packages built successfully! (All logs)

  • quill/3.6.0:
    All packages built successfully! (All logs)

  • quill/3.5.0:
    All packages built successfully! (All logs)

  • quill/3.4.0:
    All packages built successfully! (All logs)

  • quill/3.3.1:
    All packages built successfully! (All logs)

  • quill/3.5.1:
    All packages built successfully! (All logs)

  • quill/3.4.1:
    All packages built successfully! (All logs)

  • quill/3.1.0:
    All packages built successfully! (All logs)

  • quill/2.9.2:
    All packages built successfully! (All logs)

  • quill/3.0.2:
    All packages built successfully! (All logs)

  • quill/2.9.1:
    All packages built successfully! (All logs)

  • quill/2.9.0:
    All packages built successfully! (All logs)

  • quill/2.8.0:
    All packages built successfully! (All logs)

  • quill/2.6.0:
    All packages built successfully! (All logs)

  • quill/2.7.0:
    All packages built successfully! (All logs)

  • quill/1.7.3:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit a253438 into conan-io:master Jun 3, 2024
108 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants