Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/cppcommon #3224

Merged
merged 20 commits into from Nov 13, 2020
Merged

Feature/cppcommon #3224

merged 20 commits into from Nov 13, 2020

Conversation

tarc
Copy link
Contributor

@tarc tarc commented Oct 16, 2020 •
edited

Specify library name and version: cppcommon/1.0.0.0

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@CLAassistant
Copy link

CLAassistant commented Oct 16, 2020 •
edited

CLA assistant check
All committers have signed the CLA.

@conan-center-bot
Copy link
Collaborator

Failure in build 1 (afafc40fbe3ab1ff1ce170bf58caf076baaf98ee):

  • cppcommon/1.0.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "1.0.0.0" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "1.0.0.0". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052)

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 2 (a9268d86994abb244c1f9fd12c1eef3d49096ed9):

@conan-center-bot
Copy link
Collaborator

Failure in build 3 (a098078cc0253db57d41390cf6c6e471ad5baca8):

  • Error processing recipe (ref 'cppcommon/1.0.0.0'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: cppcommon:shared-False
    Unexpected error happened:
ERROR: cppcommon/1.0.0.0: Error in configure() method, line 67
	raise ConanInvalidConfiguration("This package requires c++17 support. The current compiler does not support it.")
	NameError: name 'ConanInvalidConfiguration' is not defined

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 4 (7ece9560b8b4393348355b01b2e35bb72ca28c1e):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 5 (b88d22518b1d0e044f650a0b8f29e82a38d0efd5):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 6 (0f4e264a4adec54dad5e2afc6c50dcaca59138d6):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 7 (a2ee4ccbd3d6384cc8a64538ff0635f55364b168):

@conan-center-bot
Copy link
Collaborator

Failure in build 8 (81785e4d99a15143b75f52a755fa1f5eb356b871):

  • cppcommon/1.0.0.0:
    • Zero packages generated. Looks like all configurations have been discarded by ConanInvalidConfiguration exceptions

@conan-center-bot
Copy link
Collaborator

Failure in build 9 (be4769b05a4951397d21bce5be56b15bd1781ece):

  • cppcommon/1.0.0.0:
    • Zero packages generated. Looks like all configurations have been discarded by ConanInvalidConfiguration exceptions

@tarc tarc force-pushed the feature/cppcommon branch 2 times, most recently from 5a608ab to cf78379 Compare October 16, 2020 21:23
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 10 (5a608abf2235eac0045952a0d568fb0e4f643b5d):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 11 (cf783792a55aeb315877810e030bd388c7b09e5d):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 12 (60daabfbbbc7b4151eacd794de6d8bad33022ed3):

@tarc tarc force-pushed the feature/cppcommon branch 2 times, most recently from 49dd2f0 to 22ce249 Compare October 17, 2020 23:03
@conan-center-bot
Copy link
Collaborator

An unexpected error happened and has been reported. Help is on its way! 🏇

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 14 (22ce249e81f072f3a1ac897227373251fdc8b224):

@conan-center-bot
Copy link
Collaborator

Failure in build 15 (8f66845f4b64cfc3682f529f23676dcdce64b13b):

  • cppcommon/1.0.0.0
    • Hooks errors detected:
      • [HOOK - conan-center.py] pre_export(): ERROR: [NO FINAL ENDLINE (KB-H041)] File '/home/conan/w/cci_PR-3224/recipes/cppcommon/all/conanfile.py' does not end with an endline (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H041)

@conan-center-bot
Copy link
Collaborator

All green in build 55 (bfb12da8593727fdf5f02826b40356524a854c88)! 😊

@tarc
Add pthread to linux system_libs
64f2ed6 
This amend is only to change author's email address to pass licence
check.
@conan-center-bot
Copy link
Collaborator

All green in build 56 (64f2ed6ed3d8756d9a04d6572cafc09bb7a46d77)! 😊

prince-chrismc
prince-chrismc suggested changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider tarc#3

@tarc
Merge pull request #3 from prince-chrismc/feature/cppcommon
16d7be3 
simplify cmake_wrapper + link libs + system libs
@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 57 (16d7be3de2eebd08f89a49f0e7acb1f49afeef25):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 58 (747d52df5ed02e2539345977adc1a35c4f0f4aa6):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cppcommon/1.0.0.0' failed in build 59 (3b63fa300f486293fa123788139d1d6bf40933f4):

@conan-center-bot
Copy link
Collaborator

All green in build 60 (6fddcfcae0da74971f57bedee6df7ce14d299987)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 61 (d94446a8b9c38db6bdb80260c74b6be88edc8824)! 😊

prince-chrismc
prince-chrismc reviewed Nov 7, 2020
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the trouble, I had it installed locally so I didnt have any issues 🙈

Super close, just add that comment and I can approve!

recipes/cppcommon/all/patches/00001-update-cmakelists.patch Outdated Show resolved Hide resolved
@tarc @prince-chrismc
Update recipes/cppcommon/all/patches/00001-update-cmakelists.patch
5ea1f7b 
Co-authored-by: Chris Mc <prince.chrismc@gmail.com>
prince-chrismc
prince-chrismc approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@prince-chrismc prince-chrismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@conan-center-bot
Copy link
Collaborator

All green in build 62 (5ea1f7b3691ff0f8b729233a225e2b85e3ce1a20)! 😊

@prince-chrismc prince-chrismc mentioned this pull request Nov 8, 2020
Merged
4 tasks
@tarc tarc requested a review from SSE4 November 8, 2020 06:41
@conan-center-bot conan-center-bot merged commit 07ba4bc into conan-io:master Nov 13, 2020
@tarc tarc deleted the feature/cppcommon branch November 14, 2020 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@prince-chrismc prince-chrismc prince-chrismc approved these changes

@danimtb danimtb Awaiting requested review from danimtb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@tarc @CLAassistant @conan-center-bot @prince-chrismc @SSE4 @uilianries