Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cpr #3727

Merged
merged 3 commits into from
Dec 3, 2020
Merged

Update cpr #3727

merged 3 commits into from
Dec 3, 2020

Conversation

LunarWatcher
Copy link
Contributor

Specify library name and version: cpr/1.5.2

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Fixes #3321

Admittedly, I have no idea whether this is close to working. Works on my Linux machine, but that's about it. The reason behind the error listed in #3470 is that the patch is out of date - that part of the patch is easy to fix. Minor changes in the CMake caused curl-global-scope.patch to be incorrect. I've bumped that, and cleared out find_package(CURL COMPONENTS ...) as this caused problems locally. I have no idea whether or not this makes sense or even should be done, as I don't really use CMake myself - improvements to the patch are welcome. Found the fix by comparing it to an old version of CPR, which didn't contain COMPONENTS in the find_package.

@SSE4 SSE4 requested a review from uilianries November 28, 2020 17:47
@ghost
Copy link

ghost commented Nov 28, 2020

I detected other pull requests that are modifying cpr recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'cpr/1.3.0' failed in build 1 (cab9d276fcc15b8a1cba9edff09dd9f248bf7a8b):

@LunarWatcher
Copy link
Contributor Author

LunarWatcher commented Nov 28, 2020

Hm, the other CPR PR failed on macs on v1.3.0 as well. Looks like an OpenSSL config issue, but got no idea what to do about it, if something has to be done at all. Purely a missing package from what I can tell at least, which isn't too bad

Ah, no, it's related to the linked PR. It's unfortunately stale, might take a look at that later

@conan-center-bot
Copy link
Collaborator

Failure in build 2 (db85262cab3cd26fcef6a321e1d0f49661ad63b0):

  • Error processing recipe (ref 'cpr/1.3.0'): Linux x86_64, Release, gcc 4.9, libstdc++ . Options: cpr:shared-False
    Unexpected error happened:
ERROR: cpr/1.3.0: Error in configure() method, line 37
	if self.options.with_openssl and self.options["libcurl"].with_ssl != "openssl":
	ConanException: option 'with_ssl' doesn't exist
Possible options are []

@LunarWatcher
Copy link
Contributor Author

LunarWatcher commented Nov 30, 2020

Oh, this actually doesn't have anything to do with the deprecation. libcurl has only been built with darwinssl in the Mac configurations.

@conan-center-bot
Copy link
Collaborator

All green in build 3 (d1b24d4fffdbcc63ae2b358c8786c67e67882bc9)! 😊

  • cpr/1.3.0: Generated 124 packages (+ 12 invalid config from build()). All logs here
  • cpr/1.4.0: Generated 124 packages (+ 12 invalid config from build()). All logs here
  • cpr/1.5.0: Generated 124 packages (+ 12 invalid config from build()). All logs here
  • cpr/1.5.2: Generated 124 packages (+ 12 invalid config from build()). All logs here

@prince-chrismc
Copy link
Contributor

Reading the other PR I am not sure this is the best solution : thinking: maybe just leave the check and keep the throw for it to pass

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@conan-center-bot conan-center-bot merged commit e725f03 into conan-io:master Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[request] cpr/1.5.2
5 participants