add gperftools package #4572
Closed
add gperftools package #4572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
SpaceIm
reviewed
Feb 15, 2021
Comment on lines
+37
to
+41
| if self.settings.os == "Windows" and self.settings.compiler == "Visual Studio": | ||
| raise ConanInvalidConfiguration("gperftools is not supported by Visual Studio") | ||
| if self.settings.os == "Windows" and self.options.shared: | ||
| # libtool: error: can't build i686-pc-mingw32 shared library unless -no-undefined is specified | ||
| raise ConanInvalidConfiguration("gperftools can't be built as shared on Windows") |
There was a problem hiding this comment.
Did you try with CMakeLists? It could avoid msys2 build requirement (autotools are slow as hell on windows) and allow to build with Visual Studio.
SpaceIm
reviewed
Feb 15, 2021
| topics = ("conan", "gperftools", "tcmalloc", "cpu/heap profiler") | ||
| url = "https://github.com/conan-io/conan-center-index" | ||
| homepage = "https://github.com/gperftools/gperftools" | ||
| license = ["BSD-3-Clause License"] |
There was a problem hiding this comment.
Suggested change
| license = ["BSD-3-Clause License"] | |
| license = ["BSD-3-Clause"] |
SpaceIm
reviewed
Feb 15, 2021
| if self.settings.os == "Windows": | ||
| del self.options.fPIC | ||
|
|
||
| def configure(self): |
There was a problem hiding this comment.
Suggested change
| def configure(self): | |
| def configure(self): | |
| if self.options.shared: | |
| del self.options.fPIC |
SpaceIm
reviewed
Feb 15, 2021
Comment on lines
+75
to
+80
| os.unlink(os.path.join(self.package_folder, "lib", "libprofiler.la")) | ||
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc.la")) | ||
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_and_profiler.la")) | ||
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_debug.la")) | ||
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_minimal.la")) | ||
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_minimal_debug.la")) |
There was a problem hiding this comment.
Suggested change
| os.unlink(os.path.join(self.package_folder, "lib", "libprofiler.la")) | |
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc.la")) | |
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_and_profiler.la")) | |
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_debug.la")) | |
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_minimal.la")) | |
| os.unlink(os.path.join(self.package_folder, "lib", "libtcmalloc_minimal_debug.la")) | |
| tools.remove_files_by_mask(os.path.join(self.package_folder, "lib"), "*.la") |
Comment on lines
+3
to
+5
| import os | ||
|
|
||
|
|
There was a problem hiding this comment.
Suggested change
| import os | |
| import os | |
| required_conan_version = ">=1.29.1" | |
|
Some configurations of 'gperftools/2.8.1' failed in build 2 (
|
|
Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This pull request has been automatically closed because it has not had recent activity. Thank you for your contributions. |
|
This package is really needed, since I'm granted for EAP, can I make this PR my own? |
|
@tuduongquyet, sure, you only need to write here you need to fork conan-center-index to you; add it locally |
please create a new PR (makiing a branch as described in coment above), unfortunately we cannot change an ownership of PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: lib/1.0
conan-center hook activated.