Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cubicinterpolation to conan center. #4695

Merged
merged 31 commits into from Mar 4, 2021
Merged

add cubicinterpolation to conan center. #4695

merged 31 commits into from Mar 4, 2021

Conversation

MaxSac
Copy link
Contributor

@MaxSac MaxSac commented Feb 26, 2021

This package provides interpolation utilities for common problems which are necessary to solve for high energy physics.
It's based on boost and eigen.

Specify library name and version: CubicInterpolation/0.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

This package provides utilities which are necessary for lepton and photon propagation.
It's based on boost and eigen.
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@CLAassistant
Copy link

CLAassistant commented Feb 26, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MaxSac Thanks for your contribution, please:

recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Outdated Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Show resolved Hide resolved
recipes/cubicinterpolation/all/conanfile.py Show resolved Hide resolved
MaxSac and others added 4 commits February 26, 2021 19:08
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

MaxSac and others added 2 commits February 26, 2021 19:10
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

1 similar comment
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

Co-authored-by: Uilian Ries <uilianries@gmail.com>
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@MaxSac
Copy link
Contributor Author

MaxSac commented Feb 26, 2021

@MaxSac Thanks for your contribution, please:

* Sign the CLA listed on this PR as a comment

* Asked for EAP permission on #4

* Read [How to add pacakges](https://github.com/conan-io/conan-center-index/blob/master/docs/how_to_add_packages.md), there you will find real good examples.

* Take a look on this review.

@MaxSac MaxSac closed this Feb 26, 2021
@MaxSac MaxSac reopened this Feb 26, 2021
@conan-center-bot
Copy link
Collaborator

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

@uilianries
Copy link
Member

@MaxSac The EAP is approved every Monday, there is a bot which approves new names on that list. Before that, our CI won't build your PR (that's kind of a security protocol for all PRs).

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 3, 2021

Interesting message:

C:\Program Files (x86)\Microsoft Visual Studio\2017\Community\VC\Tools\MSVC\14.16.27023\include\type_traits(1271): error C2338: You've instantiated std::aligned_storage<Len, Align> with an extended alignment (in other words, Align > alignof(max_align_t)). Before VS 2017 15.8, the member type would non-conformingly have an alignment of only alignof(max_align_t). VS 2017 15.8 was fixed to handle this correctly, but the fix inherently changes layout and breaks binary compatibility (*only* for uses of aligned_storage with extended alignments). Please define either (1) _ENABLE_EXTENDED_ALIGNED_STORAGE to acknowledge that you understand this message and that you actually want a type with an extended alignment, or (2) _DISABLE_EXTENDED_ALIGNED_STORAGE to silence this message and get the old non-conformant behavior. (compiling source file C:\J\w\BuildSingleReference\.conan\data\cubicinterpolation\0.1.2\_\_\build\1ff7763a88ed5a3cd266a893b71530abdc4de6e4\source_subfolder\src\detail\BicubicSplines.cxx) [C:\J\w\BuildSingleReference\.conan\data\cubicinterpolation\0.1.2\_\_\build\1ff7763a88ed5a3cd266a893b71530abdc4de6e4\src\CubicInterpolation.vcxproj]

I would suggest to bump min Visual Studio version to 16 for the moment.

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
SpaceIm
SpaceIm previously approved these changes Mar 3, 2021
@@ -0,0 +1,34 @@
--- a/src/CMakeLists.txt
+++ b/src/CMakeLists.txt
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you're the author of the library, may I ask you to add these changes directly to your project, release a new version and create a recipe for an updated version?

This way we will get rid of this patch, which might break in the future.
And, probably more important, your library will be easily usable in MSVC, which is be a good thing (and not just through conan).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be too much, and, if you're not ready to go an extra mile, tell me, and I will approve current changes (I don't want to stop you from sharing your lib through conan).

Copy link
Contributor Author

@MaxSac MaxSac Mar 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creating a new release is no problem at all and also my favorite solution. :)

@conan-center-bot
Copy link
Collaborator

All green in build 25 (8c9dff5c3ad72e3a417f6440fcc887ab559139b8):

  • cubicinterpolation/0.1.2@:
    All packages built successfully! (All logs)

uilianries
uilianries previously approved these changes Mar 3, 2021
SSE4
SSE4 previously approved these changes Mar 3, 2021
@MaxSac MaxSac dismissed stale reviews from SSE4, uilianries, and SpaceIm via b3a5177 March 3, 2021 17:41
@conan-center-bot
Copy link
Collaborator

Failure in build 26 (b3a51777ff685f1a2eb0f17b80501f6febd108d0):

  • cubicinterpolation/0.1.2@:
    Error running command conan export "recipes/cubicinterpolation/all/conanfile.py" cubicinterpolation/0.1.2@:
    [HOOK - conan-center.py] pre_export(): [DEPRECATED GLOBAL CPPSTD (KB-H001)] OK
    [HOOK - conan-center.py] pre_export(): [REFERENCE LOWERCASE (KB-H002)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE METADATA (KB-H003)] OK
    [HOOK - conan-center.py] pre_export(): [HEADER_ONLY, NO COPY SOURCE (KB-H005)] OK
    [HOOK - conan-center.py] pre_export(): [FPIC OPTION (KB-H006)] OK
    [HOOK - conan-center.py] pre_export(): [VERSION RANGES (KB-H008)] OK
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] Total recipe size: 6.7705078125 KB
    [HOOK - conan-center.py] pre_export(): [RECIPE FOLDER SIZE (KB-H009)] OK
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: None
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] exports: CMakeLists.txt
    [HOOK - conan-center.py] pre_export(): [EXPORT LICENSE (KB-H023)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE FOLDER (KB-H024)] OK
    [HOOK - conan-center.py] pre_export(): [META LINES (KB-H025)] OK
    [HOOK - conan-center.py] pre_export(): [CONAN CENTER INDEX URL (KB-H027)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE MINIMUM VERSION (KB-H028)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - RUN ENVIRONMENT (KB-H029)] OK
    [HOOK - conan-center.py] pre_export(): [SYSTEM REQUIREMENTS (KB-H032)] OK
    [HOOK - conan-center.py] pre_export(): [CONANDATA.YML FORMAT (KB-H030)] OK
    [HOOK - conan-center.py] pre_export(): [TEST PACKAGE - NO IMPORTS() (KB-H034)] OK
    [HOOK - conan-center.py] pre_export(): [NO AUTHOR (KB-H037)] OK
    [HOOK - conan-center.py] pre_export(): [NO TARGET NAME (KB-H040)] OK
    [HOOK - conan-center.py] pre_export(): [NO FINAL ENDLINE (KB-H041)] OK
    [HOOK - conan-center.py] pre_export(): [NO REQUIRES.ADD() (KB-H044)] OK
    [HOOK - conan-center.py] pre_export(): [DELETE OPTIONS (KB-H045)] OK
    [HOOK - conan-center.py] pre_export(): [NO ASCII CHARACTERS (KB-H047)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERBOSE MAKEFILE (KB-H046)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE VERSION REQUIRED (KB-H048)] OK
    [HOOK - conan-center.py] pre_export(): [CMAKE WINDOWS EXPORT ALL SYMBOLS (KB-H049)] OK
    [HOOK - conan-center.py] pre_export(): [DEFAULT OPTIONS AS DICTIONARY (KB-H051)] OK
    [HOOK - conan-center.py] pre_export(): [PRIVATE IMPORTS (KB-H053)] OK
    [HOOK - conan-center.py] pre_export(): [SINGLE REQUIRES (KB-H055)] OK
    [HOOK - conan-center.py] pre_export(): ERROR: [CONFIG.YML HAS NEW VERSION (KB-H052)] The version "0.1.3" exists in "conandata.yml" but not in "../config.yml", so it will not be built. Please update "../config.yml" to include newly added version "0.1.3". (https://github.com/conan-io/conan-center-index/blob/master/docs/error_knowledge_base.md#KB-H052) 
    ERROR: [HOOK - conan-center.py] pre_export(): Some checks failed running the hook, check the output
    

Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability.

Copy link
Contributor

@mathbunnyru mathbunnyru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, delete the patch :)

mathbunnyru
mathbunnyru previously approved these changes Mar 3, 2021
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot
Copy link
Collaborator

All green in build 29 (26b9ae8229489d1a4ced5475b6c56ff66e2719ee):

  • cubicinterpolation/0.1.3@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 8d89c1e into conan-io:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants