New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add cubicinterpolation to conan center. #4695
Conversation
This package provides utilities which are necessary for lepton and photon propagation. It's based on boost and eigen.
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MaxSac Thanks for your contribution, please:
- Sign the CLA listed on this PR as a comment
- Asked for EAP permission on [!!] Access request #4
- Read How to add pacakges, there you will find real good examples.
- Take a look on this review.
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Co-authored-by: Uilian Ries <uilianries@gmail.com>
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
|
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
@MaxSac The EAP is approved every Monday, there is a bot which approves new names on that list. Before that, our CI won't build your PR (that's kind of a security protocol for all PRs). |
Interesting message:
I would suggest to bump min Visual Studio version to 16 for the moment. |
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@@ -0,0 +1,34 @@ | |||
--- a/src/CMakeLists.txt | |||
+++ b/src/CMakeLists.txt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you're the author of the library, may I ask you to add these changes directly to your project, release a new version and create a recipe for an updated version?
This way we will get rid of this patch, which might break in the future.
And, probably more important, your library will be easily usable in MSVC, which is be a good thing (and not just through conan).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might be too much, and, if you're not ready to go an extra mile, tell me, and I will approve current changes (I don't want to stop you from sharing your lib through conan).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creating a new release is no problem at all and also my favorite solution. :)
All green in build 25 (
|
Failure in build 26 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, delete the patch :)
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
All green in build 29 (
|
This package provides interpolation utilities for common problems which are necessary to solve for high energy physics.
It's based on boost and eigen.
Specify library name and version: CubicInterpolation/0.1
conan-center hook activated.