simdjson: add 0.8.2 + fix compiler versions verifications #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Failure in build 1 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
SpaceIm
force-pushed
the
bump/simdjson/0.8.2
branch
from
b964653
to
1aadcd2
Compare
|
Failure in build 3 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
This was referenced Feb 28, 2021
seems to be required for gcc7
|
Failure in build 4 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
Failure in build 5 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
|
Raise the minimum compile versions? or revert the code? |
|
The problem is that gcc 7 docker images in CCI are based on gcc 7.2, while simdjson seems to require gcc 7.4 at least. |
|
All green in build 6 (
|
SSE4
approved these changes
Mar 14, 2021
prince-chrismc
approved these changes
Mar 14, 2021
a4z
approved these changes
Mar 15, 2021
mathbunnyru
reviewed
Mar 15, 2021
Comment on lines
40
to
+42
| return { | ||
| "gcc": "7.4", | ||
| "Visual Studio": "15.7", | ||
| "gcc": "8", | ||
| "Visual Studio": "16", |
There was a problem hiding this comment.
The author tells that gcc 7 is enough.
Isn't that right?
And clang 6 should work as well.
There was a problem hiding this comment.
Oh, I just saw the comment about 7.4, is it possible to keep 7.4?
There was a problem hiding this comment.
No, due to CI of CCI.
There was a problem hiding this comment.
Well if we revert the changes... than will pass for CCI and anyone using custom compiler versions like it was before
There was a problem hiding this comment.
I don't know if it's very common, there is no silver bullet here.
prince-chrismc
referenced
this pull request
in prince-chrismc/conan-center-index-pending-review
Mar 16, 2021
this will allow testing it in a preview wihtout opening an issue
prince-chrismc
referenced
this pull request
in prince-chrismc/conan-center-index-pending-review
Mar 16, 2021
prince-chrismc
referenced
this pull request
in prince-chrismc/conan-center-index-pending-review
Mar 16, 2021
prince-chrismc
referenced
this pull request
in prince-chrismc/conan-center-index-pending-review
Mar 16, 2021
uilianries
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify library name and version: simdjson/all
conan-center hook activated.