-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opencv: add more contrib options and CUDA support #4797
Conversation
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
I detected other pull requests that are modifying opencv/4.x recipe: This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't set options in configure()
Where do you control if opencv is built with freetype, harfbuzz, glog and gflags in build()
, I don't see anything.
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
Thanks for your suggestions
These dependencies are used by opencv_contrib. I'm not too sure myself if they are always necessary (even without glog, some modules requiring it are built, whereas the |
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
1 similar comment
Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue. |
if self.options.with_cuda: | ||
# This allows compilation on older GCC/NVCC, otherwise build errors. | ||
self._cmake.definitions["CUDA_NVCC_FLAGS"] = "--expt-relaxed-constexpr" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this required? Or can we set a minimum compiler requirement?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if that is necessary. I used to build older versions of OpenCV using this deprecated recipe and I copied this line from it.
According to the CUDA Toolkit documentation, this flag is experimental, therefore we cannot set a minimum compiler requirement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since it's only one compiler I think thats okay
Failure in build 6 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 7 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Apply suggestions from code review Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com> opencv: add include_dirs and libs for freetype, harfbuzz, gflags and glog opencv: add missing get_safe()
Failure in build 8 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
Failure in build 9 (
Note: To save resources, CI tries to finish as soon as an error is found. For this reason you might find that not all the references have been launched or not all the configurations for a given reference. Also, take into account that we cannot guarantee the order of execution as it depends on CI workload and workers availability. |
To be honest, I have absolutely no idea on how to fix the build failure right now :/ |
Honestly, I'm not very enthusiastic with this interface design for options. |
Actually the README from the contrib modules gives a simpler way to disable modules instead of manually giving module paths one by one.
You're absolutely right, I should have looked at it beforehand. |
this will allow testing it in a preview wihtout opening an issue
Specify library name and version: opencv/4.x
conan-center hook activated.
Currently, if CUDA is enabled, it will build for all possible archs. I don't know if it is possible to pass a list of selected archs as an option.