package DataFrame for conan-io #542

yssource · 2019-12-26T04:06:23Z

Specify library name and version: DataFrame/1.5.0

[ x] I've read the guidelines for contributing.
[ x] I've followed the PEP8 style guides for Python code in the recipes.
[ x] I've used the latest Conan client version.
[ x] I've tried at least one configuration locally with the
conan-center hook activated.

conan-center-bot · 2019-12-26T04:06:55Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2019-12-26T04:16:00Z

Sorry, the build is only launched for Early Access Program users. You can request access writing in this issue.

conan-center-bot · 2019-12-26T11:06:41Z

All green! 😊

DataFrame/1.5.0: Generated 1 packages. All logs here

recipes/DataFrame/config.yml

recipes/DataFrame/all/conanfile.py

Signed-off-by: Uilian Ries <uilianries@gmail.com>

danimtb · 2019-12-26T12:08:48Z

Don't know why this generated just 1 package 🤔

uilianries

Hi @yssource ! Thanks for your contribution, some important points:

Your recipe offers shared/static library option, by DataFrame only offer an unique type per platform
DataFrame build all its tests, but unfortunately there is no option
All packages and folder must use lowercase only

Please, take a look in my PR which contains all changes that you need to improve this PR: yssource#1

yssource · 2019-12-27T01:06:02Z

Thanks for reviews.

yssource · 2019-12-27T01:10:53Z

It's necessarily to rebase the commits, isn't it?

conan-center-bot · 2019-12-27T01:12:05Z

Some configurations of 'dataframe/1.5.0' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: dataframe:shared-False
- Hooks errors detected:
  - [HOOK - conan-center.py] post_package(): ERROR: [DEFAULT PACKAGE LAYOUT (KB-H013)] Unknown folder 'CMake' in the package (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H013)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] The conan-center repository doesn't allow the packages to contain CMake find modules or config files. The packages have to be located using generators and the declared cpp_infoinformation (https://github.com/conan-io/conan-center-index/wiki/Error-Knowledge-Base#KB-H016)
  - [HOOK - conan-center.py] post_package(): ERROR: [CMAKE-MODULES-CONFIG-FILES (KB-H016)] Found files:
- Log download
- Log error Download
- Profile
Access to all the logs

yssource · 2019-12-27T01:45:58Z

It seems the failure that is caused under "Windows x86_64". But I don't have such a guest developing environment on my local PC.

uilianries · 2019-12-27T12:43:58Z

It seems the failure that is caused under "Windows x86_64". But I don't have such a guest developing environment on my local PC.

You don't need, just check the logs provided by the CI.

The problem is that on Windows, this project copies those CMake file to self.package_folder/CMake, instead of self.package_folder/lib/cmake, like on Unix systems.

recipes/dataframe/all/conanfile.py

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2019-12-27T15:43:32Z

Some configurations of 'dataframe/1.5.0' have failed:

Windows x86_64, Debug, Visual Studio 14, MTd. Options: dataframe:shared-False
Access to all the logs

yssource · 2019-12-27T16:09:22Z

        # Remove packaging files & MS runtime files
        for dir_to_remove in [
            "cmake",
            os.path.join("lib", "cmake"),
            os.path.join("lib", "share"),
            os.path.join("lib", "pkgconfig"),
            "share"
        ]:
            tools.rmdir(os.path.join(self.package_folder, dir_to_remove))

@uilianries I'm not sure, whether it is ok or not, as above.

uilianries · 2019-12-27T18:09:02Z

@yssource You fixed one error, now you have a new one:

DataFrame requires C++17, however, MSVC 14 and MSVC 15 doesn't offer support for such cpp standard. You need to drop them by configure.

uilianries · 2019-12-27T18:12:02Z

@yssource reading again the author cmake file, it requires cpp 14 actually.

uilianries

Drop Visual Studio 14

recipes/dataframe/all/conanfile.py

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

conan-center-bot · 2019-12-28T14:49:09Z

Some configurations of 'dataframe/1.5.0' have failed:

Windows x86_64, Debug, Visual Studio 15, MTd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-False
Access to all the logs

conan-center-bot · 2019-12-29T07:12:04Z

Some configurations of 'dataframe/1.5.0' have failed:

Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-False
Access to all the logs

uilianries · 2020-01-09T12:13:01Z

recipes/dataframe/all/conanfile.py

+        ):
+            raise ConanInvalidConfiguration("DataFrame requires Visual Studio >= 16")
+        elif compiler == "apple-clang":
+            raise ConanInvalidConfiguration("DataFrame is not tested with apple-clang")


What do you mean by "not tested"? Who didn't test, you or the author? You should check if it's working on OSX.

OSX tests are commented out in the official hosseinmoein/DataFrame/.travis.yml.
emm, I will test this in my fork with travis-ci.

conan-center-bot · 2020-01-09T12:19:36Z

Some configurations of 'dataframe/1.5.0' failed in build 10 (0e9ea27c8bdf79d98ddadc30f78bac63ea1ebed0):

Linux x86_64, Release, gcc 4.9, libstdc++ . Options: dataframe:shared-True
Access to all the logs
Linux x86_64, Release, gcc 4.9, libstdc++ . Options: dataframe:shared-False
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: dataframe:shared-True
Access to all the logs
Linux x86_64, Debug, gcc 4.9, libstdc++ . Options: dataframe:shared-False
Access to all the logs

conan-center-bot · 2020-01-09T13:02:50Z

Some configurations of 'dataframe/1.5.0' failed in build 11 (ef8bafb6cb09187cb80c277de22d866600c3554a):

Windows x86_64, Debug, Visual Studio 16, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 16, MD. Options: dataframe:shared-True
Access to all the logs

conan-center-bot · 2020-01-11T14:51:57Z

Some configurations of 'dataframe/1.5.0' failed in build 12 (f0fc0975a445c73486e6e0b03a129d5b0ae8f568):

Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: dataframe:shared-False
Access to all the logs

yssource · 2020-01-11T15:02:19Z

The building on Visual Studio has troubled me for a long time.
I created a repo with the same codes and made a successful building on travis-ci and appveyor.
But, it fails to build here.

conan-center-bot · 2020-01-14T03:04:28Z

Some configurations of 'dataframe/1.5.0' failed in build 13 (9fb52c9b8630d5390f6223ec8634d264e313ecfb):

Windows x86_64, Release, Visual Studio 15, MT. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: dataframe:shared-False
Access to all the logs

uilianries · 2020-01-14T19:03:12Z

@yssource The error is:

error LNK2019: unresolved external symbol "private: static unsigned int hmdf::ThreadGranularity::num_of_threads_

The problem is that you trying to access a symbol which wasn't exported, but DataFrame project doesn't support __declspec(dllexport)/__declspec(import). Even if you force CMAKE_WINDOWS_EXPORT_ALL_SYMBOLS=ON it won't work. It's an upstream limitation.

My suggestion: Drop shared option for Windows, request such support to the upstream

uilianries · 2020-01-14T21:28:19Z

For some reason, this project is forcing MD runtime, even when is configured to MT. I didn't any clue about.

conan create . dataframe/1.5.0@ -s compiler="Visual Studio" -s compiler.version=15 -s compiler.runtime=MT

...
 cl /c /IC:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\include /W3 /WX- /diagnostics:classic /MP12 /O2 /Ob2 /D WIN32 /D _WINDOWS /D NDEBUG /D "CMAKE_INTDIR=\"Release\"" /D _MBCS /Gm- /EHsc /MD /GS /fp:precise /Zc:wchar_t /Zc:forScope /Zc:inline /GR /std:c++14 /Fo"DataFrame.dir\Release\\" /Fd"DataFrame.dir\Release\DataFrame.pdb" /Gd /TP /errorReport:queue C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\Vectors\HeteroVector.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\Vectors\HeteroView.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\Vectors\HeteroPtrView.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\Utils\ThreadGranularity.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\Utils\DateTime.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\MMap\MMapBase.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\MMap\MMapFile.cc C:\Users\uilia\.conan\data\dataframe\1.5.0\_\_\build\7d0ab7bed042914e1f2bacde0cf7e4d3b1a535bf\source_subfolder\src\MMap\MMapSharedMem.cc

conan-center-bot · 2020-01-15T16:51:10Z

Some configurations of 'dataframe/1.5.0' failed in build 14 (9fb52c9b8630d5390f6223ec8634d264e313ecfb):

Windows x86_64, Debug, Visual Studio 15, MDd. Options: dataframe:shared-True
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MT. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Debug, Visual Studio 15, MTd. Options: dataframe:shared-False
Access to all the logs
Windows x86_64, Release, Visual Studio 15, MD. Options: dataframe:shared-True
Access to all the logs

hosseinmoein#47 conan-io/conan-center-index#542

yssource · 2020-01-19T01:32:33Z

I think the commit d060e05 has resolved the dllexport problem.
And, I will re-create the package when its next release comes out.

yssource · 2020-02-07T07:35:44Z

Close. Open a new PR v1.7.0

package DataFrame for conan-io

544ba7d

conan-center-bot added the No Beta user label Dec 26, 2019

add original License

bcffaef

danimtb removed the No Beta user label Dec 26, 2019

danimtb reviewed Dec 26, 2019

View reviewed changes

recipes/DataFrame/config.yml Outdated Show resolved Hide resolved

recipes/DataFrame/all/conanfile.py Outdated Show resolved Hide resolved

uilianries added 2 commits December 26, 2019 08:59

conan-io#542 Fix shared option

b6b0c21

Signed-off-by: Uilian Ries <uilianries@gmail.com>

Remove file

93d09ce

Signed-off-by: Uilian Ries <uilianries@gmail.com>

uilianries requested changes Dec 26, 2019

View reviewed changes

yssource added 3 commits December 27, 2019 08:36

Merge branch 'uilianries-dataframe' into DataFrame

b00f727

checked with hooks.conan-center

b5d175a

reviewed

4bbbe57

conan-center-bot added the Failed label Dec 27, 2019

uilianries requested changes Dec 27, 2019

View reviewed changes

recipes/dataframe/all/conanfile.py Show resolved Hide resolved

Update recipes/dataframe/all/conanfile.py

52059d0

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

uilianries requested changes Dec 27, 2019

View reviewed changes

recipes/dataframe/all/conanfile.py Show resolved Hide resolved

recipes/dataframe/all/conanfile.py Show resolved Hide resolved

yssource and others added 2 commits December 28, 2019 22:40

Update recipes/dataframe/all/conanfile.py

80f8185

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

Update recipes/dataframe/all/conanfile.py

4f94444

Co-Authored-By: Uilian Ries <uilianries@gmail.com>

target include directories, and set cxx standard 14, instead of 17

9684ac0

yssource requested a review from uilianries December 29, 2019 11:10

Visual Studio 16, and disable apple-clang

0e9ea27

uilianries reviewed Jan 9, 2020

View reviewed changes

c++14 is required.

ef8bafb

1.6.0 release supported

f0fc097

remove runtime, use always default (MD/MDd)

9fb52c9

yssource mentioned this pull request Jan 16, 2020

Drop shared option for Windows, porting with conan supported. hosseinmoein/DataFrame#47

Closed

yssource added a commit to yssource/DataFrame that referenced this pull request Jan 18, 2020

support __declspec(dllexport)/__declspec(import).

cefc6a8

hosseinmoein#47 conan-io/conan-center-index#542

yssource closed this Feb 7, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

package DataFrame for conan-io #542

package DataFrame for conan-io #542

yssource commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

danimtb commented Dec 26, 2019

uilianries left a comment

yssource commented Dec 27, 2019

yssource commented Dec 27, 2019

conan-center-bot commented Dec 27, 2019

yssource commented Dec 27, 2019 •

edited

uilianries commented Dec 27, 2019

conan-center-bot commented Dec 27, 2019

yssource commented Dec 27, 2019

uilianries commented Dec 27, 2019

uilianries commented Dec 27, 2019

uilianries left a comment

conan-center-bot commented Dec 28, 2019

conan-center-bot commented Dec 29, 2019

uilianries Jan 9, 2020

yssource Jan 9, 2020

conan-center-bot commented Jan 9, 2020

conan-center-bot commented Jan 9, 2020

conan-center-bot commented Jan 11, 2020

yssource commented Jan 11, 2020

conan-center-bot commented Jan 14, 2020

uilianries commented Jan 14, 2020

uilianries commented Jan 14, 2020

conan-center-bot commented Jan 15, 2020

yssource commented Jan 19, 2020

yssource commented Feb 7, 2020

package DataFrame for conan-io #542

package DataFrame for conan-io #542

Conversation

yssource commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

conan-center-bot commented Dec 26, 2019

danimtb commented Dec 26, 2019

uilianries left a comment

Choose a reason for hiding this comment

yssource commented Dec 27, 2019

yssource commented Dec 27, 2019

conan-center-bot commented Dec 27, 2019

yssource commented Dec 27, 2019 • edited

uilianries commented Dec 27, 2019

conan-center-bot commented Dec 27, 2019

yssource commented Dec 27, 2019

uilianries commented Dec 27, 2019

uilianries commented Dec 27, 2019

uilianries left a comment

Choose a reason for hiding this comment

conan-center-bot commented Dec 28, 2019

conan-center-bot commented Dec 29, 2019

uilianries Jan 9, 2020

Choose a reason for hiding this comment

yssource Jan 9, 2020

Choose a reason for hiding this comment

conan-center-bot commented Jan 9, 2020

conan-center-bot commented Jan 9, 2020

conan-center-bot commented Jan 11, 2020

yssource commented Jan 11, 2020

conan-center-bot commented Jan 14, 2020

uilianries commented Jan 14, 2020

uilianries commented Jan 14, 2020

conan-center-bot commented Jan 15, 2020

yssource commented Jan 19, 2020

yssource commented Feb 7, 2020

yssource commented Dec 27, 2019 •

edited