Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add simdjson/0.2.1 #704

Merged
merged 14 commits into from
Jan 29, 2020
Merged

Add simdjson/0.2.1 #704

merged 14 commits into from
Jan 29, 2020

Conversation

theirix
Copy link
Contributor

@theirix theirix commented Jan 19, 2020 •
edited
Loading

Specify library name and version: simdjson/0.2.1

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

Fixes conan-io/wishlist#221

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 1 (c7fd504ee6e96ff5068cc5d5846a4e6426520ba8):

@theirix
Check for c++17 for simdjson
0bd0480 
Copied code from libsigcpp
@Croydon
Copy link
Contributor

Croydon commented Jan 19, 2020

Please add a Fixes https://github.com/conan-io/wishlist/issues/221 into the pull request description, so that the issues gets closed when this gets merged. Thanks!

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 2 (0bd0480d5101a23578127cfacab961b6573afa22):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 3 (6236b258a15f478ba022c97555fca775a1f9f1b7):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 4 (a6302cfc4d7c244d47d915fbde07281b90582f55):

@conan-center-bot
Copy link
Collaborator

config.yml syntax error in build 5 (null):

Only one library can be changed in the same PR: [openjpeg/all, simdjson/all]|

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 6 (e8157ff538bb0cb064141dc2210ed92a8c1482d3):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 7 (f7172e55f001d9a07b0b40193c2a34041696f020):

@gocarlos gocarlos mentioned this pull request Jan 20, 2020
Open
@SSE4
Copy link
Contributor

SSE4 commented Jan 20, 2020

seems like CMake crashes? it terminates via 1073741819 which is access violation error:

error MSB3073: "C:\Program Files\CMake\bin\cmake.exe" -E __create_def ...
...
exited with code -1073741819.

@theirix @SSE4
Update recipes/simdjson/all/conanfile.py
8d32fed 
it's vim

Co-Authored-By: SSE4 <tomskside@gmail.com>
@theirix
Copy link
Contributor Author

theirix commented Jan 20, 2020

@SSE4 yes, seems cmake is crashing. I am trying to debug this error on a Windows VM (VS 2019, x64, latest cmake from conan_cmake_installer) and it is reproduced locally but I have no idea why. It is related to post-build action (cmake property WINDOWS_EXPORT_ALL_SYMBOLS 1) when a def file is produced based on object files. No proper CMake tickets.

The simdjson is rapidly developed, I'll try master and report a bug upstream.

Maybe we just ban shared builds for simdjson on Windows?

@SSE4
Copy link
Contributor

SSE4 commented Jan 20, 2020

@theirix is it latest CMake release available?
if so, let's report it to the CMake, and disable the shared build leaving the comment to the newly created ticket.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'simdjson/0.2.1' failed in build 8 (8d32fed18c663207158a742638b6a5a64f5d80f2):

@theirix
Disable INTERPROCEDURAL_OPTIMIZATION for simdjson
b9dd6f6 
It prevents shared libraries to be built on Windows
@conan-center-bot
Copy link
Collaborator

All green in build 9 (b9dd6f6039af286a3e8932f7e45583f8d60a10e2)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 10 (ee999858dce4b0d63b7f962a845ff42eac73291f)! 😊

@theirix
Copy link
Contributor Author

theirix commented Jan 20, 2020

The problem was non-obvious. It was a conflict of enabled LTO and exporting symbols. CMake command __export_def cannot extract data from object files generated by MSVC with LTO information as well as dumpbin.exe (I think nobody can). I have disabled it for shared MSVC builds.

uilianries
uilianries requested changes Jan 20, 2020
View reviewed changes
Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great! Only smalls changes and we are good! Thanks @theirix !

recipes/simdjson/all/CMakeLists.txt Show resolved Hide resolved
recipes/simdjson/all/conanfile.py Show resolved Hide resolved
@theirix @uilianries
Link libm for simdjson
fe3c34f 
Co-Authored-By: Uilian Ries <uilianries@gmail.com>
@theirix
Copy link
Contributor Author

theirix commented Jan 20, 2020

I created a ticket simdjson/simdjson#451 in the upstream project to track our workaround in the future.

@conan-center-bot
Copy link
Collaborator

All green in build 11 (fe3c34ff95c84a23212eefa3aa213231d62d5266)! 😊

@theirix theirix requested a review from SSE4 January 21, 2020 16:03
@danimtb danimtb self-assigned this Jan 27, 2020
@danimtb danimtb merged commit f403ccb into conan-io:master Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@uilianries uilianries uilianries approved these changes

@danimtb danimtb danimtb approved these changes

Assignees

@danimtb danimtb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

simdjson: Yet Another JSON Parser
6 participants
@theirix @conan-center-bot @Croydon @SSE4 @uilianries @danimtb