Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scons/3.1.2 recipe #814

Merged
merged 20 commits into from
May 20, 2020
Merged

Add scons/3.1.2 recipe #814

merged 20 commits into from
May 20, 2020

Conversation

madebr
Copy link
Contributor

@madebr madebr commented Feb 9, 2020

Specify library name and version: scons/3.1.2

This will probably fail on Visual Studio because of an error while linking the test_package:

scons: Entering directory `C:\Users\maarten\source\repos\conan-center-index\recipes\scons\all\test_package'
scons: Reading SConscript files ...
conan-compiler tool is msvc
CC is: cl
scons: done reading SConscript files.
scons: Building targets ...
scons: building associated VariantDir targets: build\882726301a296ee1f7f1d98a3db2003150ea70a8
cl /Fobuild\882726301a296ee1f7f1d98a3db2003150ea70a8\test_package.obj /c test_package.c /nologo
test_package.c
link /nologo /OUT:build\882726301a296ee1f7f1d98a3db2003150ea70a8\test_package.exe /LIBPATH:C:\Users\maarten\.conan\data\scons\3.1.2\_\_\package\5ab84d6acfe1f23c4fae0ab88f26e3a396351ac9\lib build\882726301a296ee1f7f1d98a3db2003150ea70a8\test_package.obj
LINK : fatal error LNK1104: cannot open file 'C:\WINDOWS\lnk{ECD57055-886D-4616-BDF6-EE1EDE9390CA}.tmp'
scons: *** [build\882726301a296ee1f7f1d98a3db2003150ea70a8\test_package.exe] Error 1104
scons: building terminated because of errors.
ERROR: scons/3.1.2 (test package): Error in build() method, line 29
        self.run("scons -C \"{}\" {} --conan-compiler={}".format(self.source_folder, debug_opt, self._script_tool[str(self.settings.compiler)]))
        ConanException: Error 2 while executing scons -C "C:\Users\maarten\source\repos\conan-center-index\recipes\scons\all\test_package"  --conan-compiler=msvc

This is the same error as this bug report: https://scons-users.scons.narkive.com/FRzlVB7H/msvc-error
I think this is a bug in either scons or msvc.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot
Copy link
Collaborator

All green in build 1 (864d89bf36b7c2c1a9877818fbe6f70b84acb957)! 😊

@conan-center-bot
Copy link
Collaborator

Some configurations of 'scons/3.1.2' failed in build 2 (683a2ab12169c2410ce8ecd02fefe7a02e3ac938):

@conan-center-bot
Copy link
Collaborator

All green in build 3 (becd97e439c8878860e2b51b0cd30b2471a898a7)! 😊

@madebr
Copy link
Contributor Author

madebr commented Feb 9, 2020

Works on my pc ==> Works on CI ™️ 😅

@conan-center-bot
Copy link
Collaborator

All green in build 4 (90c73c54d62f61a8bbbf6fd1323d361b3f555eef)! 😊

@conan-center-bot
Copy link
Collaborator

All green in build 5 (14dacc5416ae4ac801bb87960c0096aed3f86043)! 😊

SSE4
SSE4 previously approved these changes Feb 25, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 6 (029b08f7c107d076e290d93d03e08022302e375d)! 😊

uilianries
uilianries previously approved these changes Feb 26, 2020
SSE4
SSE4 previously approved these changes Mar 2, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 8 (029b08f7c107d076e290d93d03e08022302e375d)! 😊

@danimtb danimtb self-assigned this Mar 12, 2020
@fulara
Copy link
Contributor

fulara commented Apr 29, 2020

@madebr
I also needed to change your sys.executable to just plain invocations of python.
this is because when conan is bundled with the pyinstaller the sys.executable is conan.
So the build fails.

Could this scenario be handled?

@conan-center-bot
Copy link
Collaborator

All green in build 19 (808dda93981913fbfecf77736d60a0aa6bc7a7b3)! 😊

@conan-center-bot
Copy link
Collaborator

Some configurations of 'scons/3.1.2' failed in build 21 (0e244f4316355e4d3c88c14e67ae08e3af58ca57):

@madebr madebr closed this Apr 30, 2020
@madebr madebr reopened this Apr 30, 2020
@conan-center-bot
Copy link
Collaborator

All green in build 22 (96955f0eeca726c3a5442d30a2600599db0c9c2c)! 😊

@madebr madebr mentioned this pull request Apr 30, 2020
7 tasks
@madebr
Copy link
Contributor Author

madebr commented May 4, 2020

Should this recipe (optionally) depend on #1510 for a build requirement?
Should we expect users to have a python interpreter installed and available?
Users of the standalone windows conan.exe can be expected to add cpython to the build_requirements section of its profile.

@madebr
Copy link
Contributor Author

madebr commented May 13, 2020

@uilianries @danimtb @SSE4 @jgsogo
Is something holding this back?
I think I addressed the issue about potentially downloading external dependencies.

@conan-center-bot
Copy link
Collaborator

Some configurations of 'scons/3.1.2' failed in build 23 (b1272a6dcf4ecde25fb37171677e9a9a2e4f79fb):

@conan-center-bot
Copy link
Collaborator

Some configurations of 'scons/3.1.2' failed in build 24 (d0ba94135259d76fc024a492e841ea9501ec76bc):

@conan-center-bot
Copy link
Collaborator

All green in build 25 (aee92c7bdb799ebb2a937dd5e352e440ed92810c)! 😊

Copy link
Member

@danimtb danimtb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This recipe has some hacky aspects but it made the CI pass so... However, we have to keep in mind that this is a special recipe to consider for future use cases.

@SSE4 SSE4 merged commit c589124 into conan-io:master May 20, 2020
@madebr madebr deleted the scons branch May 20, 2020 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants