Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebp: relocatable shared lib on macOS + modernize #9036

Merged
merged 3 commits into from
Feb 2, 2022

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Jan 22, 2022

see conan-io/hooks#376


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

SSE4
SSE4 previously approved these changes Jan 23, 2022
@conan-center-bot

This comment has been minimized.

@ghost
Copy link

ghost commented Jan 25, 2022

I detected other pull requests that are modifying libwebp/all recipe:

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@SpaceIm SpaceIm requested a review from SSE4 January 25, 2022 10:00
@SpaceIm SpaceIm changed the title libwebp: modernize libwebp: relocatable shared lib on macOS + modernize Jan 25, 2022
@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Jan 27, 2022
@SpaceIm SpaceIm reopened this Jan 27, 2022
@conan-center-bot

This comment has been minimized.

@prince-chrismc
Copy link
Contributor

😖

conan test conan-center-index/recipes/libwebp/all/test_package/conanfile.py libwebp/1.2.2@ --profile=/Users/jenkins/w/BuildSingleReference/78257/d92a02be-9c85-4288-8737-60d279a475af/profile.txt

libwebp/1.2.2: Retrieving package 859f8116a362ef830363626989ec41f658f4e574 from remote 'c3i_PR-9036' 
ERROR: Binary package not found: 'libwebp/1.2.2:859f8116a362ef830363626989ec41f658f4e574'

@SpaceIm SpaceIm closed this Jan 27, 2022
@SpaceIm SpaceIm reopened this Jan 27, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm SpaceIm closed this Jan 28, 2022
@SpaceIm SpaceIm reopened this Jan 28, 2022
@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Jan 28, 2022

Installing (downloading, building) binaries...
libwebp/1.2.2: Retrieving package 859f8116a362ef830363626989ec41f658f4e574 from remote 'c3i_PR-9036' 
ERROR: Binary package not found: 'libwebp/1.2.2:859f8116a362ef830363626989ec41f658f4e574'

@jgsogo Any idea on this one? test package fails to retrieve the package.

@SpaceIm SpaceIm closed this Jan 31, 2022
@SpaceIm SpaceIm reopened this Jan 31, 2022
@conan-center-bot

This comment has been minimized.

@jgsogo
Copy link
Contributor

jgsogo commented Jan 31, 2022

If it is a dependency of the test_package/conanfile.py it's probably this same issue: #9089 (comment)

I'll try to bypass it with the tools we have currently (it might work), if not, I'm preparing some changes to be deployed soon

It doesn't look like the same, sorry, I read conan test and thought about it. Let me have a closer look.

@conan-center-bot
Copy link
Collaborator

All green in build 17 (a37e2f26f5cf65c88782473296a8c6adf230083e):

  • libwebp/1.2.1@:
    All packages built successfully! (All logs)

  • libwebp/1.2.2@:
    All packages built successfully! (All logs)

  • libwebp/1.2.0@:
    All packages built successfully! (All logs)

  • libwebp/1.1.0@:
    All packages built successfully! (All logs)

  • libwebp/1.0.3@:
    All packages built successfully! (All logs)

@jgsogo
Copy link
Contributor

jgsogo commented Jan 31, 2022

Here the problem was a wrong package (incomplete one) uploaded to Artifactory, the conanmanifest.txt file was missing. We have requested Artifactory team to provide some kind of atomic uploads for Conan packages, but still the feature is in the backlog. While this is developed, Conan packages can face this issue in concurrent scenarios.

@prince-chrismc
Copy link
Contributor

The merge commit persevered our approvals but the bot only looks at the head commit

This needs one more uilianries review is not being counted according to my bot 😢

@uilianries
Copy link
Member

let's try to recount

@conan-center-bot conan-center-bot merged commit 687effb into conan-io:master Feb 2, 2022
@SpaceIm SpaceIm deleted the libwebp-modernize branch February 2, 2022 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants