itk: add components #9237
Merged
itk: add components #9237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
uilianries
previously approved these changes
Feb 4, 2022
Nekto89
previously approved these changes
Feb 8, 2022
SSE4
previously approved these changes
Feb 21, 2022
SpaceIm
dismissed stale reviews from SSE4, Nekto89, and uilianries
via
e44dd73
This comment has been minimized.
This comment has been minimized.
SSE4
reviewed
Mar 11, 2022
| @@ -140,7 +140,7 @@ | |||
| -itk_module_target(itkopenjpeg NO_INSTALL) | |||
| +find_package(OpenJPEG REQUIRED) | |||
| +add_library(itkopenjpeg INTERFACE) | |||
| +set_property(TARGET itkopenjpeg PROPERTY INTERFACE_LINK_LIBRARIES OpenJPEG::OpenJPEG) | |||
| +set_property(TARGET itkopenjpeg PROPERTY INTERFACE_LINK_LIBRARIES openjp2) | |||
There was a problem hiding this comment.
should we fix target name in openjpeg?
There was a problem hiding this comment.
Are they incorrect? If yes, I agree changing
There was a problem hiding this comment.
openjp2 is the official target, nothing to change in openjpeg recipe
SSE4
approved these changes
Mar 11, 2022
prince-chrismc
approved these changes
Mar 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
conan-center hook activated.