Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocksdb: modernize #9362

Merged
merged 3 commits into from
Mar 3, 2022
Merged

Conversation

SpaceIm
Copy link
Contributor

@SpaceIm SpaceIm commented Feb 12, 2022


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

also depends on onetbb recipe instead of tbb (deprecated)
@conan-center-bot
Copy link
Collaborator

All green in build 1 (c13e66e5eb019f91006cb68fb8d8e3812f073cb9):

  • rocksdb/6.8.1@:
    All packages built successfully! (All logs)

  • rocksdb/6.20.3@:
    All packages built successfully! (All logs)

  • rocksdb/6.0.2@:
    All packages built successfully! (All logs)

  • rocksdb/6.10.2@:
    All packages built successfully! (All logs)

Copy link
Member

@uilianries uilianries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 21, 2022

It would be better to merge #9164 before this one.

@SSE4
Copy link
Contributor

SSE4 commented Feb 21, 2022

It would be better to merge #9164 before this one.

sounds reasonable. I am blocking it for a while.

@SSE4 SSE4 added the blocked Affected by an external issue and waiting until it is solved label Feb 21, 2022
@SpaceIm
Copy link
Contributor Author

SpaceIm commented Feb 26, 2022

@SSE4 no need to block this PR anymore. #9164 has been merged.

@SSE4 SSE4 removed the blocked Affected by an external issue and waiting until it is solved label Feb 27, 2022
@conan-center-bot conan-center-bot merged commit a00de66 into conan-io:master Mar 3, 2022
@SpaceIm SpaceIm deleted the rocksdb-modernize branch March 3, 2022 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants