Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Libsodium MSVC bugfix for #8957 #9391

Merged
merged 4 commits into from
Feb 17, 2022
Merged

Libsodium MSVC bugfix for #8957 #9391

merged 4 commits into from
Feb 17, 2022

Conversation

willadsen
Copy link
Contributor

Specify library name and version: libsodium/1.0.18

Libsodium is missing vs 2022 compatibility, hence this PR.

  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

@willadsen willadsen changed the title VS 2022 compatibility Libsodium VS 2022 compatibility Feb 15, 2022
@conan-center-bot

This comment has been minimized.

Sign in to view
@willadsen @SpaceIm
Update recipes/libsodium/all/conanfile.py
8c77ccc 
Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot

This comment has been minimized.

Sign in to view
@conan-center-bot
Copy link
Collaborator

All green in build 4 (1e08f974e39a4a3458f2ac972e5e946d3d125786):

  • libsodium/1.0.18@:
    All packages built successfully! (All logs)

@prince-chrismc prince-chrismc mentioned this pull request Feb 16, 2022
Open
@SpaceIm
Copy link
Contributor

SpaceIm commented Feb 16, 2022

The title should be updated.

@willadsen willadsen changed the title Libsodium VS 2022 compatibility Libsodium MSVC bugfix for #8957 Feb 16, 2022
@conan-center-bot conan-center-bot merged commit 921f907 into conan-io:master Feb 17, 2022
SSE4 pushed a commit to madebr/conan-center-index that referenced this pull request Feb 21, 2022
@willadsen @SpaceIm @SSE4
(conan-io#9391) Libsodium MSVC bugfix for conan-io#8957
3b53020 
* VS 2022 compatibility

* Update recipes/libsodium/all/conanfile.py

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>

* revert vs2022 folder lookup

Co-authored-by: SpaceIm <30052553+SpaceIm@users.noreply.github.com>
@willadsen willadsen deleted the libsodium-vs2022 branch August 8, 2022 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SSE4 SSE4 SSE4 approved these changes

@ericLemanissier ericLemanissier ericLemanissier approved these changes

@SpaceIm SpaceIm SpaceIm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@willadsen @conan-center-bot @SpaceIm @SSE4 @ericLemanissier