Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix windows clang compilation for ffi #9988

Merged

Conversation

AndreyMlashkin
Copy link
Contributor

@AndreyMlashkin AndreyMlashkin commented Mar 29, 2022

Specify library name and version: libffi/3.4.2@

This is also a good place to share with all of us why you are submitting this PR (specially if it is a new addition to ConanCenter): is it a dependency of other libraries you want to package? Are you the author of the library? Thanks!

closes: #9954


  • I've read the guidelines for contributing.
  • I've followed the PEP8 style guides for Python code in the recipes.
  • I've used the latest Conan client version.
  • I've tried at least one configuration locally with the
    conan-center hook activated.

SSE4
SSE4 previously approved these changes Mar 29, 2022
Copy link
Contributor

@SSE4 SSE4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it doesn't break MinGW, Intel, whatever else may run on Windows

@conan-center-bot

This comment has been minimized.

@AndreyMlashkin
Copy link
Contributor Author

I hope it doesn't break MinGW, Intel, whatever else may run on Windows

adding m64 was ignored for clang and it will be also ignored for mingw :)

@AndreyMlashkin
Copy link
Contributor Author

How to restart the build?

@uilianries
Copy link
Member

How to restart the build?

You just did it. close/open the PR works too.

@conan-center-bot

This comment has been minimized.

@SpaceIm
Copy link
Contributor

SpaceIm commented Mar 29, 2022

this approach seems neater: #9993

@conan-center-bot

This comment has been minimized.

@conan-center-bot

This comment has been minimized.

@conan-center-bot
Copy link
Collaborator

All green in build 8 (209d84f22fb3a69dd57e4ab5b8fe1549aea500c6):

  • libffi/3.2.1@:
    All packages built successfully! (All logs)

  • libffi/3.3@:
    All packages built successfully! (All logs)

  • libffi/3.4.2@:
    All packages built successfully! (All logs)

@conan-center-bot conan-center-bot merged commit 00dbcae into conan-io:master Apr 1, 2022
@AndreyMlashkin AndreyMlashkin deleted the fix_windows_clang_for_ffi branch April 1, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[package] libffi/3.4.2: can't build with windows clang
7 participants