fix restore not exist file (#16113)

conan-io · Apr 19, 2024 · 20bf653 · 20bf653
1 parent 517e2b7
commit 20bf653
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/conan/api/subapi/cache.py b/conan/api/subapi/cache.py
@@ -155,6 +155,8 @@ def save(self, package_list, tgz_path):
             tgz.close()
 
     def restore(self, path):
+        if not os.path.isfile(path):
+            raise ConanException(f"Restore archive doesn't exist in {path}")
         with open(path, mode='rb') as file_handler:
             the_tar = tarfile.open(fileobj=file_handler)
             fileobj = the_tar.extractfile("pkglist.json")

diff --git a/conans/test/integration/command_v2/test_cache_save_restore.py b/conans/test/integration/command_v2/test_cache_save_restore.py
@@ -211,3 +211,9 @@ def test_cache_save_subfolder():
     c.run("export .")
     c.run("cache save * --file=subfolder/cache.tgz")
     assert os.path.exists(os.path.join(c.current_folder, "subfolder", "cache.tgz"))
+
+
+def test_error_restore_not_existing():
+    c = TestClient()
+    c.run("cache restore potato.tgz", assert_error=True)
+    assert "ERROR: Restore archive doesn't exist in " in c.out