Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature] Documentation missing for CMAKE_OSX_DEPLOYMENT_TARGET flag in cmake build helper #10335

Open
1 task done
eliasreid opened this issue Jan 13, 2022 · 2 comments
Open
1 task done
Assignees

Comments

@eliasreid
Copy link

#9301 Added the feature to set the CMAKE_OSX_DEPLOYMENT_TARGET from the settings.os.version, but it appears that the documentation for this is missing on the CMake build helper page: https://docs.conan.io/en/latest/reference/build_helpers/cmake.html#definitions

@memsharded
Copy link
Member

Hi @eliasreid

You are looking at the wrong documentation. The one related to that PR (CMakeToolchain) is in https://docs.conan.io/en/latest/reference/conanfile/tools/cmake.html

@eliasreid
Copy link
Author

eliasreid commented Jan 13, 2022

Ok, I didn't realize that there was two classes both named CMake, thank you.

I think the PR I linked is not relevant, but the issue still is. When I look at the code for https://github.com/conan-io/conan/blob/develop/conans/client/build/cmake_flags.py, it appears that CMAKE_OSX_DEPLOYMENT_TARGET is being set, but it is not documented in the table at https://docs.conan.io/en/latest/reference/build_helpers/cmake.html#definitions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants