Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Use CMAKE_OSX_DEPLOYMENT_TARGET to get -version-min set in CMakeToolchain #9301

Merged
merged 2 commits into from Jul 21, 2021

Conversation

SSE4
Copy link
Contributor

@SSE4 SSE4 commented Jul 21, 2021

/cc @ssrobins
closes: #9282
set CMAKE_OSX_DEPLOYMENT_TARGET to the os.version value for macOS, iOS, watchOS, tvOS
also, remove the leftover variable DEPLOYMENT_TARGET which doesn't seem to be used/needed

Changelog: Feature: Use CMAKE_OSX_DEPLOYMENT_TARGET to get -version-min set in CMakeToolchain.
Docs: omit

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

Signed-off-by: SSE4 <tomskside@gmail.com>
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some unittest (no need functional or integration)

@memsharded memsharded added this to the 1.39 milestone Jul 21, 2021
Signed-off-by: SSE4 <tomskside@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use CMAKE_OSX_DEPLOYMENT_TARGET to get -version-min set in CMakeToolchain
2 participants