Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass ANDROID_ABI & ANDROID_NDK variables to cmake #4537

Closed
CAMOBAP opened this issue Feb 17, 2019 · 4 comments · Fixed by #4538
Closed

Pass ANDROID_ABI & ANDROID_NDK variables to cmake #4537

CAMOBAP opened this issue Feb 17, 2019 · 4 comments · Fixed by #4538

Comments

@CAMOBAP
Copy link
Contributor

CAMOBAP commented Feb 17, 2019

Intro

Recently In bincrafters/conan-libwebp#5 I faced with issues conan don't forward ANDROID_ABI variable and didn't have any way to pass ANDROID_NDK to cmake script too

Most of libraries with cmake build system which support Android expect these variables

Proposal

Pass ANDROID_ABI which can be determined from os.settings.arch
Pass ANDROID_NDK if ANDROID_NDK_HOME environment variable defined (name of env variable can be discussed)

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Feb 21, 2019

Looks like make sense to care about ANDROID_NDK_ROOT too

@venabled
Copy link

venabled commented Apr 9, 2019

Also helpful even if you pass the Platform/Level somewhere as well, detectable from op_system_version

            ret["ANDROID_PLATFORM"] = op_system_version

@CAMOBAP
Copy link
Contributor Author

CAMOBAP commented Apr 9, 2019

@venabled ANDROID_PLATFORM isn't just api level it's in format android-$api_level

BTW PR already contains this

@venabled
Copy link

venabled commented Apr 9, 2019

Copy, didn't follow the conversation into the PR. Will try out that branch here shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants