Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] intel functions exposed under tools without prefix #7820

Closed
solvingj opened this issue Oct 5, 2020 · 1 comment · Fixed by #7821
Closed

[bug] intel functions exposed under tools without prefix #7820

solvingj opened this issue Oct 5, 2020 · 1 comment · Fixed by #7821
Milestone

Comments

@solvingj
Copy link
Contributor

solvingj commented Oct 5, 2020

Starting with Conan version 1.30.0, the following existing intel-related functions are made public use inside conanfile.py.

  • tools.compilervars()
  • tools.compilervars_dict()
  • tools.compilervars_command()

Physically, these functions live in the conans.client.tools.intel package, but are "exposed' to conanfile.py under the tools package:
from tools import compilervars

Unfortunately, exposing them directly under the tools package makes the function names ambiguous. For clarity, these function should be renamed to begin with the prefix of intel_.

Environment Details (include every applicable attribute)

  • Operating System+version: All
  • Compiler+version: Intel all
  • Conan version: 1.30.0
  • Python version: All
@memsharded
Copy link
Member

memsharded commented Oct 6, 2020

Closed by #7821

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants