new PkgConfigDeps generator creates wrong gtest suite pc files

[Makogan]

Environment Details (include every applicable attribute)

• Operating System+version: Ubuntu 21.04
• Compiler+version: g++ 11
• Conan version: 1.40.1
• Python version: 3.9.5

Steps to reproduce (Include if Applicable)

Use PkgConfigDeps to download gtest as a dependency and if I set it to install teh pc files in a directory other than the build directory. I get the pc files:

gtest.pc
gtest-libgtest.pc

Inside gtest.pc I see:

Name: gtest
Description: Conan package: gtest
Version: 1.10.0
Requires: libgtest gtest_main gmock gmock_main

The libraries are wrong, it should be, for example gtest-libgtest, and manually changing the files to have that prefix solves the issue.

This does not happen if I install the files in the build directory using the old pkg_config generator, in that case I do get a plain libgtest.pc file.

[memsharded]

Hi @Makogan

Do you mean the line shot be something like?

Requires: gtest-libgtest gtest-gtest_main gtest-gmock gtest-gmock_main

So it includes the other .pc file as transitive dependency automatically?

Yes, this seems a bug, lets try to fix it for next release. Thanks for reporting!

[memsharded]

Btw, it could be something missing in the recipe itself, needs to be checked. I see something like:

 self.cpp_info.components["libgtest"].names["cmake_find_package"] = "gtest"
        self.cpp_info.components["libgtest"].names["cmake_find_package_multi"] = "gtest"
        self.cpp_info.components["libgtest"].libs = ["gtest{}".format(self._postfix)]

Which is the legacy way of setting names. It is possible that the new PkgConfigDeps uses only the new properties or something like that, and the recipe needs to be modernized too.

[Makogan]

@memsharded Yes, that's what I mean, all the lib names are missing the prefix, I am not sure about the recipes, I have yet to write one myself so I am not in a good position to give feedback about it.

[franramirez688]

Thanks @Makogan

You're completely right. There was a bug when the Requires names were composed by <PKG>-<COMPONENT>. Now it's solved in this PR #9635

[memsharded]

#9635 merged, will be released in next 1.41 (can be tested now from "develop" branch). Thanks!

[Makogan]

Happy to have helped!