Bugfix: PkgConfigDeps generator creates bad Requires references
#9635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
approved these changes
Sep 20, 2021
| ret["%s.pc" % pkg_genname] = self._pc_file_content(pkg_genname, dep.new_cpp_info, | ||
| require_public_deps, | ||
| self._get_public_require_deps(dep), |
There was a problem hiding this comment.
This looks like was getting a list before, and now is going to receive tuples. Or at least the change is not evident.
There was a problem hiding this comment.
We were getting a list of tuples before, and now a list of strings. I think it's clearer now because we were not using all the values returned.
Completely agree. I think we need to make a refactor and use templates instead to keep it simpler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Fixed bad
Requiresdeclaration in*.pcfiles.Closes: #9631
Docs: omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.