Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

simplify parallel jobs #10068

Merged
merged 8 commits into from Dec 1, 2021
Merged

simplify parallel jobs #10068

merged 8 commits into from Dec 1, 2021

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented Nov 23, 2021 •
edited

Changelog: Fix: Simplify parallel definition in new conf, leaving only tools.build:jobs. Use max number of CPUs by default to build in parallel.
Docs: conan-io/docs#2308

Close #10030

@memsharded memsharded added this to the 1.43 milestone Nov 23, 2021
@memsharded memsharded mentioned this pull request Nov 23, 2021
Closed
@memsharded
Copy link
Member Author

@czoido there is a pending issue with VS /m and /MP flags, but maybe there is a way to move this forward without it?

Check discussion in #10030 (comment)

@memsharded memsharded marked this pull request as ready for review December 1, 2021 00:53
@memsharded
Copy link
Member Author

I have decided:

tools.build:jobs => Sets the /MP (compile file parallelism, similar to Make, Ninja -jX). By default is max num cores
tools.microsoft.msbuild:max_cpu_count =>sets /m (project level parallelism). Not defined by default

Also, added /MP to MSBuildToolchain
Made value of tools:build:jobs=0 => don't do anything, do not add any flag, not default to max num cores.

@czoido czoido merged commit bc83dfa into conan-io:develop Dec 1, 2021
@memsharded memsharded deleted the feature/simplify_parallel_jobs branch December 1, 2021 13:11
@memsharded memsharded mentioned this pull request Dec 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

@czoido czoido czoido approved these changes

Assignees

@czoido czoido

Labels
None yet
Projects
None yet
Milestone
1.43
Development

Successfully merging this pull request may close these issues.

[bug] conan.tools.cmake CMakeToolchain doesn't do parallel builds
3 participants
@memsharded @lasote @czoido