Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple CMake User Toolchain #10178

Merged
merged 8 commits into from Dec 20, 2021
Merged

Multiple CMake User Toolchain #10178

merged 8 commits into from Dec 20, 2021

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Dec 14, 2021 •
edited

Close #9724

Changelog: Feature: The CMakeToolchain is now prepared to apply several user toolchains.
Docs: conan-io/docs#2340

@lasote lasote added this to the 1.44 milestone Dec 20, 2021
@lasote lasote changed the title ConfAggregator + Multiple CMake User Toolchain Multiple CMake User Toolchain Dec 20, 2021
@lasote lasote marked this pull request as ready for review December 20, 2021 15:23
memsharded
memsharded approved these changes Dec 20, 2021
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks better and less complicated than previous approaches.

conans/test/functional/toolchains/cmake/test_cmake_toolchain.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 51ba070 into conan-io:develop Dec 20, 2021
@lasote lasote mentioned this pull request Dec 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

Assignees

@memsharded memsharded

Labels
None yet
Projects
None yet
Milestone
1.44
Development

Successfully merging this pull request may close these issues.

[feature] How CMakeToolchain could handle multiple user toolchains
2 participants
@lasote @memsharded