making aggregate_components non-destructive, very dangerous #10183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lasote
approved these changes
Dec 17, 2021
|
|
||
|
|
||
| def test_cpp_info_component_error_aggregate(): | ||
| # https://github.com/conan-io/conan/issues/10176 |
There was a problem hiding this comment.
Linking the issue and describing the test is very nice, but, when the assert is only kind of "this is working" would be great to describe here why exactly "consumer/1.0 (test package): Running test()" was not in the output before the fix without reading the whole issue thread.
czoido
approved these changes
Dec 17, 2021
franramirez688
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Bugfix: Making aggregate_components non-destructive, which was causing errors in generators with components.
Docs: Omit
Fix: #10176
I have removed the requirement to do a
copy()before anaggregate_components()because forgetting to do that was causing a super-challenging to debug and understand behavior. Nowaggregated_components()return a copy (cached) of the aggregated information, but never destroys the current one. Take into account that users building their owngenerate()logic or their own generators will very often need to aggregate the components information (for example MSBuildDeps and AutoToolsDeps already need to do it), and missing to do thecopy()results in this very problematic bug.Fix: #10176