[bugfix] msvc in legacy cmake generators

[franramirez688]

Changelog: Bugfix: Compiler msvc was not working for CMake legacy generators.
Docs: omit

Closes: #10185

• Refer to the issue that supports this Pull Request.
• If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
• I've read the Contributing guide.
• I've followed the PEP8 style guides for Python code.
• I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

^{Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.}

[franramirez688]

TODO: one functional test with msvc compiler

UPDATE: Done

[SSE4]

I think it's okay if the legacy generator doesn't support a new compiler, as we discussed in #9370. they are going to die very soon anyway.

[lasote]

The problem is with conan-center, before introducing the new generators we are breaking every recipe just because we now detect the msvc instead of Visual Studio, we want to push the migration, but not too much, this is a trade-off, and the fix is quite easy.

[LeeRuns]

PLEASE explain how we are supposed to build a project today in a stable way with vs2022.
For those of us who use this platform, we cannot just wait for 2.0 to release

[memsharded]

@LeeRuns please check the release notes, this was fixed in #10457 for 1.45, it is now detecting by default Visual Studio instead msvc.

And in any case, using the automatically detected profiles is not recommended for production, but using your own profile, which can define compiler="Visual Studio"

[LeeRuns]

How do I configure ninja and msvc? Chemical & Biological Engineer periodic wizbang

…

On Sun, Feb 20, 2022, 9:17 AM James ***@***.***> wrote: @LeeRuns <https://github.com/LeeRuns> please check the release notes, this was fixed in #10457 <#10457> for 1.45, it is now detecting by default Visual Studio instead msvc. And in any case, using the automatically detected profiles is not recommended for production, but using your own profile, which can define compiler="Visual Studio" — Reply to this email directly, view it on GitHub <#10195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADZNMPRVAQHN73E25X3GXB3U4EHY5ANCNFSM5KJEJ4GA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[memsharded]

@LeeRuns the modern integrations require very little configuration. Basically this works:

$ conan new hello/0.1 --template=cmake_lib
$ conan create . -c tools.cmake.cmaketoolchain:generator=Ninja

This builds with Visual Studio and Ninja generator, both the package and the consumer project inside the test_package folder.

[LeeRuns]

Ok, thanks for the clarification.

…

On Mon, Feb 21, 2022, 3:14 PM James ***@***.***> wrote: @LeeRuns <https://github.com/LeeRuns> the modern integrations require very little configuration. Basically this works: $ conan new hello/0.1 --template=cmake_lib $ conan create . -c tools.cmake.cmaketoolchain:generator=Ninja This builds with Visual Studio and Ninja generator, both the package and the consumer project inside the test_package folder. — Reply to this email directly, view it on GitHub <#10195 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADZNMPVHXMO2I6Y5PLIKANTU4K2K7ANCNFSM5KJEJ4GA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>