Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Added mandatory fields when VS 2022 auto-detection #10322

Merged

Conversation

franramirez688
Copy link
Contributor

@franramirez688 franramirez688 commented Jan 12, 2022

Changelog: Bugfix: Visual Studio 2022 auto-detected profile was incomplete.
Docs: omit

Closes: #10302

  • Refer to the issue that supports this Pull Request.
  • If the issue has missing info, explain the purpose/use case/pain/need that covers this Pull Request.
  • I've read the Contributing guide.
  • I've followed the PEP8 style guides for Python code.
  • I've opened another PR in the Conan docs repo to the develop branch, documenting this one.

Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.

conans/client/conf/detect.py Outdated Show resolved Hide resolved
Co-authored-by: SSE4 <tomskside@gmail.com>
@memsharded
Copy link
Member

Please @franramirez688 fix the test and you can merge it when green.

@franramirez688 franramirez688 merged commit 77cf310 into conan-io:develop Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] Visual Studio 2022 auto-detected profile is incomplete
3 participants