Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign SystemPackageTool interface #10380

Merged
merged 33 commits into from Jan 22, 2022
Merged

Redesign SystemPackageTool interface #10380

merged 33 commits into from Jan 22, 2022

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Jan 19, 2022 •
edited

Changelog: Feature: New tools in conan.tools.system for invoking system package managers in recipes.
Docs: conan-io/docs#2379

To discuss:

  • Check if we want to remove the guard to not running twice the system_requirements method. Add a conf for this?
  • Taking into account build_requires
  • Adding distro -> pm mapping
    ...

Closes: #1659

@czoido czoido added this to the 1.45 milestone Jan 19, 2022
memsharded
memsharded reviewed Jan 19, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design and approach is looking good, good job.

conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
@czoido czoido marked this pull request as ready for review January 20, 2022 17:26
memsharded
memsharded reviewed Jan 20, 2022
View reviewed changes
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
conans/test/integration/tools/system/package_manager.py Outdated Show resolved Hide resolved
conan/tools/system/package_manager.py Show resolved Hide resolved
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
conan/tools/system/package_manager.py Outdated Show resolved Hide resolved
memsharded
memsharded approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@memsharded memsharded merged commit 45d7983 into conan-io:develop Jan 22, 2022
@czoido czoido mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.45
Development

Successfully merging this pull request may close these issues.

Redesign SystemPackageTool interface
3 participants
@czoido @lasote @memsharded