Add missing tools to develop #10536
Merged
Add missing tools to develop #10536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Feb 8, 2022
There was a problem hiding this comment.
I think I am missing something. https://github.com/czoido/conan-center-index/pull/4/files doesn't seem to need all these tools. Aren't those insufficiently tested internally in the test-suite?
conan/tools/build/flags.py
Outdated
| from conans.model.version import Version | ||
|
|
||
|
|
||
| def architecture_flag(settings): |
There was a problem hiding this comment.
Just to make sure, most of these are internal in 2.0 to the toolchains and other helpers. If they are backported to 1.X we should make sure:
- They are not documented as public, they are not exported via
from conan.tools.xxxx - I would expect the consumers (toolchains) using these to have been changed.
- Recall that it is possible that we want to pass
conanfileas the first argument always to all public tools, so this might need a refactor for that.
No, I think we don't need all of these, I'll remove some |
memsharded
approved these changes
Feb 8, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Feature: Port
conan.tools.Versionto Conan 1.X.Changelog: Feature: Port
conan.tools.build.cross_buildingto Conan 1.X.Docs: conan-io/docs#2434
Later moved Version to conan.tools.scm.Version in #10712
There were some tools that are not ported to Conan 1.X, this PR was failing because of that.