SystemPackageTool: fix mode=verify #10596
Conversation
In this case, never install any package fixes #10592
| @@ -169,11 +170,12 @@ def install_packages(self, packages, update=True, force=False, arch_names=None): | |||
| % "\n".join(packages)) | |||
| return | |||
|
|
|||
| if mode == "verify" and not self._installed(packages): | |||
| if mode == "verify" and self._to_be_installed(packages): | |||
There was a problem hiding this comment.
This might not be ok, as in this context the packages is a list of alternate package names, not about different packages. So to_be_installed() will always return something if a list of names is provided.
I'd say with the return fix, it should be ok, can you please check? Thanks!
There was a problem hiding this comment.
Really? I thought install_packages was made to install all the packages https://docs.conan.io/en/latest/reference/conanfile/methods.html#systempackagetool
There was a problem hiding this comment.
Oh, ok, my bad, I was confused by the Github diff, didn't realize this was inside the install_packages.
You are right, this is ok.
| @@ -169,11 +170,12 @@ def install_packages(self, packages, update=True, force=False, arch_names=None): | |||
| % "\n".join(packages)) | |||
| return | |||
|
|
|||
| if mode == "verify" and not self._installed(packages): | |||
| if mode == "verify" and self._to_be_installed(packages): | |||
There was a problem hiding this comment.
Oh, ok, my bad, I was confused by the Github diff, didn't realize this was inside the install_packages.
You are right, this is ok.
In this case, never install any package
fixes #10592
Changelog: Bugfix: Fix
SystemPackageToolwhenmode=verify, it was still installing packages.Docs: Omit
developbranch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.