Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new sdk_version setting for Apple OS's and new XcodeBuild, XcodeToolchain tools #10608

Merged
merged 56 commits into from Mar 1, 2022
Merged

Add new sdk_version setting for Apple OS's and new XcodeBuild, XcodeToolchain tools #10608

merged 56 commits into from Mar 1, 2022

Conversation

czoido
Copy link
Contributor

@czoido czoido commented Feb 17, 2022 •
edited

Changelog: Feature: Add sdk_version setting for Macos, iOS, watchOS and tvOS.
Changelog: Feature: Add new XcodeBuild build helper.
Changelog: Feature: Add new XcodeToolchain helper.
Docs: conan-io/docs#2431

Closes: #9608

Superseeds: #9873

#TAGS: slow

@czoido czoido marked this pull request as ready for review February 18, 2022 13:36
@czoido czoido marked this pull request as draft February 18, 2022 15:11
memsharded
memsharded reviewed Feb 22, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and solid so far (from my ignorance of the Apple ecosystem)

conan/tools/apple/xcodedeps.py Show resolved Hide resolved
conan/tools/cmake/toolchain.py Outdated Show resolved Hide resolved
conan/tools/meson/toolchain.py Outdated Show resolved Hide resolved
@czoido czoido marked this pull request as ready for review February 23, 2022 11:05
memsharded
memsharded approved these changes Feb 28, 2022
View reviewed changes
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodedeps.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodetoolchain.py Outdated Show resolved Hide resolved
conan/tools/cmake/toolchain.py Outdated Show resolved Hide resolved
@memsharded memsharded assigned lasote and franramirez688 and unassigned lasote Feb 28, 2022
@memsharded memsharded mentioned this pull request Feb 28, 2022
Closed
1 task
memsharded
memsharded reviewed Feb 28, 2022
View reviewed changes
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/apple/xcodebuild.py Outdated Show resolved Hide resolved
conan/tools/cmake/toolchain/blocks.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit fd05f3f into conan-io:develop Mar 1, 2022
@memsharded memsharded mentioned this pull request Mar 1, 2022
Closed
@czoido czoido mentioned this pull request Mar 3, 2022
Merged
@NoWiseMan
Copy link
Contributor

great to see this additions to conan before WWDC 2022 takes place.
thx a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@memsharded memsharded memsharded approved these changes

@franramirez688 franramirez688 franramirez688 approved these changes

@lasote lasote Awaiting requested review from lasote

Assignees

@franramirez688 franramirez688

Labels
None yet
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

[feature] SDK Version for apple OSes
5 participants
@czoido @NoWiseMan @franramirez688 @memsharded @lasote