Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

exports are not sources, not copied if layout() #10625

Merged
merged 1 commit into from
Feb 22, 2022
Merged

exports are not sources, not copied if layout() #10625

merged 1 commit into from
Feb 22, 2022

Conversation

memsharded
Copy link
Member

Changelog: Fix: When layout() is defined, the exports will not be considered sources anymore, but only the exports_sources. The exports are used exclusively by the recipe, but not as package source.
Docs: Omit

Continuation of #10612
Preparation for #10594

@memsharded memsharded added this to the 1.46 milestone Feb 21, 2022
@memsharded memsharded marked this pull request as ready for review February 21, 2022 22:04
@lasote lasote self-requested a review February 22, 2022 16:00
lasote
lasote approved these changes Feb 22, 2022
View reviewed changes
Copy link
Contributor

@lasote lasote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do it 🍔

@lasote lasote merged commit a43c1eb into conan-io:develop Feb 22, 2022
@memsharded memsharded deleted the feature/layout_exports_arent_sources branch February 22, 2022 16:21
@puetzk puetzk mentioned this pull request Apr 28, 2023
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lasote lasote lasote approved these changes

Assignees

@lasote lasote

Labels
None yet
Projects
None yet
Milestone
1.46
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@memsharded @lasote