Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic_layout and external_sources for cmake_layout, removed meson_layout #10659

Merged

Conversation

lasote
Copy link
Contributor

@lasote lasote commented Feb 24, 2022

Changelog: Feature: Added basic_layout, removed meson_layout and added argument src_folder to cmake_layoutas a shortcut for adjusting conanfile.folders.source.
Docs: conan-io/docs#2426

Close #10645

@lasote lasote added this to the 1.46 milestone Feb 24, 2022
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic

@czoido
Copy link
Contributor

czoido commented Feb 28, 2022

Why cmake_layout(self, external_sources=True) and not cmake_layout(self, src_folder="whatever") ? 🤔

@lasote
Copy link
Contributor Author

lasote commented Feb 28, 2022

That's is a good question @czoido , cc @memsharded

@memsharded
Copy link
Member

Why cmake_layout(self, external_sources=True) and not cmake_layout(self, src_folder="whatever")

Indeed a good question. I guess we wanted to emphasize the fact that this argument is intended to work with external sources, which was the problem being addressed. But yes, that would be more generic and flexible, lets change it.

conan/tools/cmake/layout.py Outdated Show resolved Hide resolved
Copy link
Member

@memsharded memsharded left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My comment can be discussed or addressed later, good for me

conan/tools/cmake/layout.py Outdated Show resolved Hide resolved
@memsharded memsharded merged commit 48b15da into conan-io:develop Mar 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature] [2.0] predefined layouts when playing locally
3 participants