CMAKE_MAKE_PROGRAM for mingw #10770
Merged
CMAKE_MAKE_PROGRAM for mingw #10770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
memsharded
reviewed
Mar 14, 2022
lasote
changed the title
memsharded
reviewed
Mar 14, 2022
memsharded
approved these changes
Mar 14, 2022
| arg_list.append('-DCMAKE_SH="CMAKE_SH-NOTFOUND"') | ||
| cmake_make_program = self._conanfile.conf.get("tools.gnu:make_program", default=None) |
There was a problem hiding this comment.
I have had a second look, just in case, and it really seems difficult.
So I am approving and merging this. However, I think it would be better if we started storing this arguments in CMakeToolchain in the conanbuild.conf file, or even better, if we start considering moving to a CMakePresets.json compatible format.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Set
-DCMAKE_MAKE_PROGRAMwhen the generator is for MinGW and the conftools.gnu:make_programis set.Docs: omit