New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add meson properties field, and specificy needs_exe_wrapper depending… #10846
Add meson properties field, and specificy needs_exe_wrapper depending… #10846
Conversation
Err... I assume you mean something other than the |
Maybe? That's where I've seen most examples of exe_wrappers being set. Feel free to correct me here. |
Also, for the case of (arch_build != arch_host), do you think it makes sense to be explicit here re: needs_exe_wrapper when meson probably guess this correctly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some tests that covers this would be necessary. I'd recommend an integration test, doesn't need to actually build anything, just check the generated file contents under several conditions.
5653957
to
3b0d4c3
Compare
… on cross conditions.
3b0d4c3
to
ab0a84c
Compare
Test for presence of fields in Android and iOS cross builds, and test for lack of presence in a native build. @memsharded let me know what you think. Seemed to make more sense to put the tests there rather in anything under integration/. |
@memsharded any update feedback? |
Merged for 1.47, thanks! |
… on cross conditions.
Changelog: Feature: Add detection in meson toolchain for cross conditions and requirement of needs_exe_wrapper. Users may specify the exe wrapper in their meson.build now.
Docs: omit
Issue: #10796
Not sure if docs are required, as this is probably expected behavior of the generator for someone who understands what meson is looking for. Happy to write some docs, though.
develop
branch, documenting this one.Note: By default this PR will skip the slower tests and will use a limited set of python versions. Check here how to increase the testing level by writing some tags in the current PR body text.