Add DCMAKE_BUILD_TYPE to markdown generator instructions #11220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think it is worth a patch release only for this. If we have other fixes for a 1.48.1, then yes, I'd try to include this one too. |
czoido
added a commit
to czoido/conan
that referenced
this pull request
May 12, 2022
czoido
added a commit
that referenced
this pull request
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog: Fix: Add
-DCMAKE_BUILD_TYPEto markdown generator instructions for CMake single config.Docs: omit
After the changes introduced in 1.48 that the toolchain no longer contains the build type these instructions were not correct.
Should we port this to 1.48.1?