New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More flexibility in Autotools tools to override arguments and avoid all default arguments #11284
Merged
memsharded
merged 30 commits into
conan-io:develop
from
czoido:not_shared_default_configure_args
May 27, 2022
Merged
Changes from 20 commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
b96c4ea
add test
czoido ffd7be3
wip
czoido e41235b
wip
czoido 91603ac
wip
czoido fbe442e
mark test
czoido 5538f09
change name
czoido 2117429
minor changes
czoido fea7846
wip
czoido 3a07f21
build_script_folder in configure
czoido de526f1
Merge branch 'develop' into not_shared_default_configure_args
czoido b8dcb19
put configure bacl
czoido 5150cbe
wip
czoido 88a65f4
revert
czoido 32b767b
change name
czoido e4ee626
remove second configure
czoido 39d7961
revert
czoido 47a14a6
fix test
czoido b0e2b88
make it more configurable
czoido d5fd070
wip
czoido 04220ce
update test
czoido c0af7be
add shared flags by default
czoido e1f0256
Merge branch 'develop' of github.com:conan-io/conan into not_shared_d…
czoido 0aec634
update method
czoido b3f3000
refactor and remove default_configure_install_args
czoido a4f2a17
update test
czoido b4f3b0c
add cpp to mock
czoido fecc5da
review
czoido 64d15e1
raise in mock
czoido 9af677a
update test
czoido 502fac7
remove with-pic
czoido File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a common pattern in Conan that
self.run
needs to join arguments. It would be pretty neat if, run could accept an iterable and automatically join them:For Conan v2.0 where we can shed Python 2, I'd change that API to force keywords and allow passing multiple arguments:
Then it can be used more naturally: