Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid empty paths in runenv #11298

Merged
merged 2 commits into from May 18, 2022

Conversation

memsharded
Copy link
Member

@memsharded memsharded commented May 18, 2022

Changelog: Fix: Avoid empty paths in run environments PATH, LD_LIBRARY_PATH, DYLD_LIBRARY_PATH env-vars.
Docs: Omit

@memsharded memsharded added this to the 1.49 milestone May 18, 2022
@memsharded memsharded marked this pull request as ready for review May 18, 2022 17:11
Copy link
Contributor

@franramirez688 franramirez688 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@@ -367,6 +367,7 @@ def generate(self):
self.output.info("MYVAR2: {}!!!".format(runenv.get("MYVAR2")))
self.output.info("MYVAR3: {}!!!".format(runenv.get("MYVAR3")))
self.output.info("MYVAR4: {}!!!".format(runenv.get("MYVAR4")))
env.generate()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@franramirez688 franramirez688 merged commit 0a27518 into conan-io:develop May 18, 2022
@memsharded memsharded deleted the fix/env_avoid_empty_paths branch May 18, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants